From: Christoph Hellwig <hch@infradead.org>
To: Zubin Mithra <zsm@chromium.org>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, groeck@chromium.org,
keescook@chromium.org
Subject: Re: [PATCH] x86/pci: Annotate 'pci_root_ops' with __ro_after_init
Date: Mon, 5 Nov 2018 13:57:45 -0800 [thread overview]
Message-ID: <20181105215745.GB3160@infradead.org> (raw)
In-Reply-To: <20181105201735.72026-1-zsm@chromium.org>
On Mon, Nov 05, 2018 at 12:17:35PM -0800, Zubin Mithra wrote:
> When CONFIG_X86_INTEL_MID is set pci_root_ops is written to inside
> intel_mid_pci_init(which is marked __init) and not modified after. This
> makes pci_root_ops a suitable candidate for annotating as
> __ro_after_init.
Yikes. pci_root_ops really should be const to start with, and we
should use a separate struct for MID. Having structures that contain
function pointers not marked const is generally a bad idea to start with.
prev parent reply other threads:[~2018-11-05 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 20:17 [PATCH] x86/pci: Annotate 'pci_root_ops' with __ro_after_init Zubin Mithra
2018-11-05 21:38 ` Thomas Gleixner
2018-11-05 21:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105215745.GB3160@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=groeck@chromium.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=zsm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).