From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: bhelgaas@google.com, isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver
Date: Sun, 11 Nov 2018 10:23:47 -0800 (PST) [thread overview]
Message-ID: <20181111.102347.179167538258592040.davem@davemloft.net> (raw)
In-Reply-To: <f35fbe1d-b1f3-c0f8-82d6-18b0c7cda0b4@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 11 Nov 2018 11:50:08 +0100
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 69f0abe1b..1fac231fe 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2359,6 +2359,10 @@
>
> #define PCI_VENDOR_ID_SYNOPSYS 0x16c3
>
> +#define PCI_VENDOR_ID_USR 0x16ec
> +#define PCI_DEVICE_ID_USR_997902 0x0116
> +#define PCI_DEVICE_ID_USR_6692 0x3409
> +
> #define PCI_VENDOR_ID_VITESSE 0x1725
> #define PCI_DEVICE_ID_VITESSE_VSC7174 0x7174
Generally, as I understand the policy for linux/pci_ids.h, we only add
things used in multiple locations.
So PCI_VENDOR_ID_USR is OK, since it is used in both r8169 and w6692.
But the device IDs are not, since only w6692 uses them.
next prev parent reply other threads:[~2018-11-11 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 23:43 [PATCH net-next 0/2] r8169: add USR PCI vendor id Heiner Kallweit
2018-11-10 23:45 ` [PATCH net-next 1/2] PCI: add USR " Heiner Kallweit
2018-11-11 10:08 ` kbuild test robot
2018-11-10 23:47 ` [PATCH net-next 2/2] r8169: use proper constant for PCI vendor USR instead of numerical id Heiner Kallweit
2018-11-13 5:44 ` kbuild test robot
2018-11-11 10:50 ` [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver Heiner Kallweit
2018-11-11 18:23 ` David Miller [this message]
2018-11-11 19:31 ` [PATCH net-next v3] " Heiner Kallweit
2018-11-11 22:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111.102347.179167538258592040.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).