From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30D0C43441 for ; Tue, 27 Nov 2018 18:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADE0F2086B for ; Tue, 27 Nov 2018 18:10:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADE0F2086B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725752AbeK1FJh (ORCPT ); Wed, 28 Nov 2018 00:09:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47656 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbeK1FJg (ORCPT ); Wed, 28 Nov 2018 00:09:36 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9778FC0587E8; Tue, 27 Nov 2018 18:10:53 +0000 (UTC) Received: from redhat.com (ovpn-116-85.ams2.redhat.com [10.36.116.85]) by smtp.corp.redhat.com (Postfix) with SMTP id B577E6266E; Tue, 27 Nov 2018 18:10:44 +0000 (UTC) Date: Tue, 27 Nov 2018 13:10:43 -0500 From: "Michael S. Tsirkin" To: Jean-Philippe Brucker Cc: "iommu@lists.linux-foundation.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "joro@8bytes.org" , Mark Rutland , Lorenzo Pieralisi , "tnowicki@caviumnetworks.com" , Marc Zyngier , Robin Murphy , Will Deacon , "eric.auger@redhat.com" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "kvmarm@lists.cs.columbia.edu" Subject: Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver Message-ID: <20181127131031-mutt-send-email-mst@kernel.org> References: <20181122193801.50510-1-jean-philippe.brucker@arm.com> <20181122193801.50510-6-jean-philippe.brucker@arm.com> <20181123164716-mutt-send-email-mst@kernel.org> <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 27 Nov 2018 18:10:53 +0000 (UTC) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Nov 27, 2018 at 05:58:18PM +0000, Jean-Philippe Brucker wrote: > On 23/11/2018 21:48, Michael S. Tsirkin wrote: > >> +struct virtio_iommu_config { > >> + /* Supported page sizes */ > >> + __u64 page_size_mask; > >> + /* Supported IOVA range */ > >> + struct virtio_iommu_range input_range; > >> + /* Max domain ID size */ > >> + __u8 domain_bits; > >> + __u8 padding[3]; > > > > Not enough padding here it seems. Structure is 8 byte > > aligned on 64 bit systems. > > The next field (probe_size) is 4 bytes, so the alignment ends up fine. > That field is introduced in patch 6, maybe I should move it here? > > Thanks, > Jean Sounds like a good idea. -- MST