* [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments
@ 2018-12-01 16:07 Benjamin Young
2018-12-06 20:44 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Young @ 2018-12-01 16:07 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, linux-kernel
Made spacing more consistent in the code for function pointer
declarations based on checkpatch.pl
Signed-off-by: Benjamin Young <youngcdev@gmail.com>
---
drivers/pci/pcie/portdrv.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
index e495f04..fbbf00b0 100644
--- a/drivers/pci/pcie/portdrv.h
+++ b/drivers/pci/pcie/portdrv.h
@@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)
struct pcie_port_service_driver {
const char *name;
- int (*probe) (struct pcie_device *dev);
- void (*remove) (struct pcie_device *dev);
- int (*suspend) (struct pcie_device *dev);
- int (*resume_noirq) (struct pcie_device *dev);
- int (*resume) (struct pcie_device *dev);
- int (*runtime_suspend) (struct pcie_device *dev);
- int (*runtime_resume) (struct pcie_device *dev);
+ int (*probe)(struct pcie_device *dev);
+ void (*remove)(struct pcie_device *dev);
+ int (*suspend)(struct pcie_device *dev);
+ int (*resume_noirq)(struct pcie_device *dev);
+ int (*resume)(struct pcie_device *dev);
+ int (*runtime_suspend)(struct pcie_device *dev);
+ int (*runtime_resume)(struct pcie_device *dev);
/* Device driver may resume normal operations */
void (*error_resume)(struct pci_dev *dev);
/* Link Reset Capability - AER service driver specific */
- pci_ers_result_t (*reset_link) (struct pci_dev *dev);
+ pci_ers_result_t (*reset_link)(struct pci_dev *dev);
int port_type; /* Type of the port this driver can handle */
u32 service; /* Port service this device represents */
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments
2018-12-01 16:07 [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments Benjamin Young
@ 2018-12-06 20:44 ` Bjorn Helgaas
2018-12-06 20:50 ` Benjamin Young
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2018-12-06 20:44 UTC (permalink / raw)
To: Benjamin Young; +Cc: linux-pci, linux-kernel
On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote:
> Made spacing more consistent in the code for function pointer
> declarations based on checkpatch.pl
>
> Signed-off-by: Benjamin Young <youngcdev@gmail.com>
Applied to pci/misc for v4.21, thanks!
I also made similar changes to include/linux/pci.h. For trivial changes
like this I like to fix similar issues in all of PCI at the same time.
> ---
> drivers/pci/pcie/portdrv.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> index e495f04..fbbf00b0 100644
> --- a/drivers/pci/pcie/portdrv.h
> +++ b/drivers/pci/pcie/portdrv.h
> @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)
>
> struct pcie_port_service_driver {
> const char *name;
> - int (*probe) (struct pcie_device *dev);
> - void (*remove) (struct pcie_device *dev);
> - int (*suspend) (struct pcie_device *dev);
> - int (*resume_noirq) (struct pcie_device *dev);
> - int (*resume) (struct pcie_device *dev);
> - int (*runtime_suspend) (struct pcie_device *dev);
> - int (*runtime_resume) (struct pcie_device *dev);
> + int (*probe)(struct pcie_device *dev);
> + void (*remove)(struct pcie_device *dev);
> + int (*suspend)(struct pcie_device *dev);
> + int (*resume_noirq)(struct pcie_device *dev);
> + int (*resume)(struct pcie_device *dev);
> + int (*runtime_suspend)(struct pcie_device *dev);
> + int (*runtime_resume)(struct pcie_device *dev);
>
> /* Device driver may resume normal operations */
> void (*error_resume)(struct pci_dev *dev);
>
> /* Link Reset Capability - AER service driver specific */
> - pci_ers_result_t (*reset_link) (struct pci_dev *dev);
> + pci_ers_result_t (*reset_link)(struct pci_dev *dev);
>
> int port_type; /* Type of the port this driver can handle */
> u32 service; /* Port service this device represents */
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments
2018-12-06 20:44 ` Bjorn Helgaas
@ 2018-12-06 20:50 ` Benjamin Young
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Young @ 2018-12-06 20:50 UTC (permalink / raw)
To: helgaas; +Cc: linux-pci, open list
Thanks, I will do that next time :)
On Thu, Dec 6, 2018 at 12:44 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote:
> > Made spacing more consistent in the code for function pointer
> > declarations based on checkpatch.pl
> >
> > Signed-off-by: Benjamin Young <youngcdev@gmail.com>
>
> Applied to pci/misc for v4.21, thanks!
>
> I also made similar changes to include/linux/pci.h. For trivial changes
> like this I like to fix similar issues in all of PCI at the same time.
>
> > ---
> > drivers/pci/pcie/portdrv.h | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> > index e495f04..fbbf00b0 100644
> > --- a/drivers/pci/pcie/portdrv.h
> > +++ b/drivers/pci/pcie/portdrv.h
> > @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)
> >
> > struct pcie_port_service_driver {
> > const char *name;
> > - int (*probe) (struct pcie_device *dev);
> > - void (*remove) (struct pcie_device *dev);
> > - int (*suspend) (struct pcie_device *dev);
> > - int (*resume_noirq) (struct pcie_device *dev);
> > - int (*resume) (struct pcie_device *dev);
> > - int (*runtime_suspend) (struct pcie_device *dev);
> > - int (*runtime_resume) (struct pcie_device *dev);
> > + int (*probe)(struct pcie_device *dev);
> > + void (*remove)(struct pcie_device *dev);
> > + int (*suspend)(struct pcie_device *dev);
> > + int (*resume_noirq)(struct pcie_device *dev);
> > + int (*resume)(struct pcie_device *dev);
> > + int (*runtime_suspend)(struct pcie_device *dev);
> > + int (*runtime_resume)(struct pcie_device *dev);
> >
> > /* Device driver may resume normal operations */
> > void (*error_resume)(struct pci_dev *dev);
> >
> > /* Link Reset Capability - AER service driver specific */
> > - pci_ers_result_t (*reset_link) (struct pci_dev *dev);
> > + pci_ers_result_t (*reset_link)(struct pci_dev *dev);
> >
> > int port_type; /* Type of the port this driver can handle */
> > u32 service; /* Port service this device represents */
> > --
> > 2.5.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-06 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-01 16:07 [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments Benjamin Young
2018-12-06 20:44 ` Bjorn Helgaas
2018-12-06 20:50 ` Benjamin Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).