* [PATCH] PCI: Add missing include to drivers/pci.h
@ 2018-11-28 22:28 Alexandru Gagniuc
2018-12-06 20:56 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Gagniuc @ 2018-11-28 22:28 UTC (permalink / raw)
To: bhelgaas
Cc: austin_bolen, alex_gagniuc, keith.busch, Shyam_Iyer, lukas,
Alexandru Gagniuc, linux-pci, linux-kernel
This files makes use of definitions provided in <linux/pci.h>. This
only compiles when <linux/pci.h> is included beforehand, and creates
a nasty include dependency. Instead, just include the correct file.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
drivers/pci/pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 662b7457db23..224d88634115 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -2,6 +2,8 @@
#ifndef DRIVERS_PCI_H
#define DRIVERS_PCI_H
+#include <linux/pci.h>
+
#define PCI_FIND_CAP_TTL 48
#define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: Add missing include to drivers/pci.h
2018-11-28 22:28 [PATCH] PCI: Add missing include to drivers/pci.h Alexandru Gagniuc
@ 2018-12-06 20:56 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2018-12-06 20:56 UTC (permalink / raw)
To: Alexandru Gagniuc
Cc: austin_bolen, alex_gagniuc, keith.busch, Shyam_Iyer, lukas,
linux-pci, linux-kernel
On Wed, Nov 28, 2018 at 04:28:04PM -0600, Alexandru Gagniuc wrote:
> This files makes use of definitions provided in <linux/pci.h>. This
> only compiles when <linux/pci.h> is included beforehand, and creates
> a nasty include dependency. Instead, just include the correct file.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Applied to pci/misc for v4.21, thanks!
> ---
> drivers/pci/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 662b7457db23..224d88634115 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -2,6 +2,8 @@
> #ifndef DRIVERS_PCI_H
> #define DRIVERS_PCI_H
>
> +#include <linux/pci.h>
> +
> #define PCI_FIND_CAP_TTL 48
>
> #define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-06 20:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-28 22:28 [PATCH] PCI: Add missing include to drivers/pci.h Alexandru Gagniuc
2018-12-06 20:56 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).