From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4214C67839 for ; Fri, 14 Dec 2018 13:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BAA220672 for ; Fri, 14 Dec 2018 13:12:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ifatlMqq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BAA220672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729707AbeLNNML (ORCPT ); Fri, 14 Dec 2018 08:12:11 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43834 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729699AbeLNNMK (ORCPT ); Fri, 14 Dec 2018 08:12:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cg/FZeN/jTwq9z9tK6bfxxJ2iCsJ6q4oil+PxinbC3s=; b=ifatlMqqOUfqtdrB4WHZDwyUx Jh9+klzxMd+FBTl2dVsnxBiaHAhLwy4ld9gxtxHibCs0TDLjgM3RQdrGyAgo+gzzTodvoobJFhRGy bTNEOekJskyjcSSi3RiuCt/kNP9w2MHWJDrZ8Tg2CiiuoThl6ztMrk8Qs8fuwGC+1Xa6rK61hzmtG 0+V4vbnoBJ/4knfNyF5NhlFdjWnjCQ8u2oVCbB/qOxlpQidAIz+x6M7LuuEkee9N4XeV1k32KxYnA AT6fD54VHRzCim7w3IQkOXDik/4Dmm3W8+pBJ//0iU84Qmin/V2Z7vOVsC3CaOgwpz7qJpPZ2zmYl 0eEq4Ds2w==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXnGB-00014U-0H; Fri, 14 Dec 2018 13:12:07 +0000 Date: Fri, 14 Dec 2018 05:12:06 -0800 From: Christoph Hellwig To: Sebastian Ott Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Russell Currey , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Message-ID: <20181214131206.GA2606@infradead.org> References: <20181212215453.GJ99796@google.com> <20181213175428.87520-1-sebott@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213175428.87520-1-sebott@linux.ibm.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Dec 13, 2018 at 06:54:27PM +0100, Sebastian Ott wrote: > Move VF detection and device creation code to weak functions > such that architectures can provide a different implementation. No magic weak functions please. If you really have a reason to override the implementation add a proper Kconfig symbol and an explicit override.