[PATCH v2 00/12] Bring suspend to RAM support to PCIe Aardvark driver

Miquel Raynal
2018-12-12T10:23:17Z

Hello,

As part of an effort to bring suspend to RAM support to Armada 3700
SoCs (main target: ESPRESSObin), this series handles the work around
the PCIe IP.

First, more configuration is done in the 'setup' helper as inspired
from the U-Boot driver. This is needed to entirely initialize the IP
during future resume operation (patch 1).

Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As
current device trees do not provide the corresponding properties, not
finding one of these properties is not an error and just produces a
warning. However, if the property is present, an error during PHY
initialization will fail the probe of the driver.

Note: To be sure the clock will be resumed before this driver, a first
series adding links between clocks and consumers has been submitted,
see [1]. Anyway, having the clock series applied first is not needed.

Patch 5 adds suspend/resume hooks, re-using all the above.

Finally, bindings and device trees are updated to reflect the hardware
(patch 6-12). While the clock depends on the SoC, the reset GPIO and
the PHY depends on the board so the clock is added in the
armada-37xx.dtsi file while the two other properties are added in
armada-3720-espressobin.dts.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html

Thanks,
Miquèl

Changes since v1:
=================
* Change the capitalization in commit titles to follow the PCI
subsystem rules.
* Added Suggested-by tag to the patch adding PHY support and to the
patch adding the PHY property in the DT.
* Added Rob's Reviewed-by tags on bindings.
* I am following the discussion about calling functions that might
sleep in a NOIRQ context. As there is no real problem yet (as per my
understanding), I did not change anything on this regard.

Miquel Raynal (12):
PCI: aardvark: Configure more registers in the configuration helper
PCI: aardvark: Add reset GPIO support
PCI: aardvark: Add PHY support
PCI: aardvark: Add clock support
PCI: aardvark: Add suspend to RAM support
dt-bindings: PCI: aardvark: Describe the reset-gpios property
dt-bindings: PCI: aardvark: Describe the clocks property
dt-bindings: PCI: aardvark: Describe the PHY property
ARM64: dts: marvell: armada-37xx: declare PCIe reset pin
ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO
ARM64: dts: marvell: armada-37xx: declare PCIe clock
ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY

.../devicetree/bindings/pci/aardvark-pci.txt | 9 +
.../dts/marvell/armada-3720-espressobin.dts | 4 +
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 +
drivers/pci/controller/pci-aardvark.c | 214 ++++++++++++++++++
4 files changed, 232 insertions(+)

--
2.19.1