From: Maya Nakamura <m.maya.nakamura@gmail.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, haiyangz@microsoft.com,
marcelo.cerri@canonical.com, lorenzo.pieralisi@arm.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
kys@microsoft.com, sthemmin@microsoft.com, olaf@aepfle.de,
apw@canonical.com, jasowang@redhat.com, mikelley@microsoft.com,
Alexander.Levin@microsoft.com
Subject: Re: [PATCH 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
Date: Fri, 25 Jan 2019 16:32:40 -0800 [thread overview]
Message-ID: <20190126003239.GB1837@m-hyperV> (raw)
In-Reply-To: <87sgxi19oy.fsf@vitty.brq.redhat.com>
On Thu, Jan 24, 2019 at 02:12:13PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@gmail.com> writes:
>
> > @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> > struct msi_controller msi_chip;
> > struct irq_domain *irq_domain;
> >
> > - /* hypercall arg, must not cross page boundary */
> > - struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > -
> > spinlock_t retarget_msi_interrupt_lock;
> >
> > struct workqueue_struct *wq;
> > +
> > + /* hypercall arg, must not cross page boundary */
> > + struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > +
> > + /*
> > + * Don't put anything here: retarget_msi_interrupt_params must be last
> > + */
>
> This change seems to be unrelated and not anyhow described in the commit
> message - or did I miss something?
>
Thank you for pointing that out. I will add why it was moved in v2.
Maya
>
> --
> Vitaly
next prev parent reply other threads:[~2019-01-26 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 20:58 [PATCH 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset() Maya Nakamura
2019-01-23 21:00 ` [PATCH 1/2] PCI: hv: Replace hv_vp_set with hv_vpset Maya Nakamura
2019-01-24 13:12 ` Vitaly Kuznetsov
2019-01-26 0:32 ` Maya Nakamura [this message]
2019-01-23 21:02 ` [PATCH 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset() Maya Nakamura
2019-01-24 12:29 ` Dan Carpenter
2019-01-26 0:22 ` Maya Nakamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126003239.GB1837@m-hyperV \
--to=m.maya.nakamura@gmail.com \
--cc=Alexander.Levin@microsoft.com \
--cc=apw@canonical.com \
--cc=bhelgaas@google.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marcelo.cerri@canonical.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).