From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3863C169C4 for ; Thu, 31 Jan 2019 16:25:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEEDF20B1F for ; Thu, 31 Jan 2019 16:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388068AbfAaQZt (ORCPT ); Thu, 31 Jan 2019 11:25:49 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:45330 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731284AbfAaQZs (ORCPT ); Thu, 31 Jan 2019 11:25:48 -0500 Received: from relay9-d.mail.gandi.net (unknown [217.70.183.199]) by mslow2.mail.gandi.net (Postfix) with ESMTP id AFEF13A9B76 for ; Thu, 31 Jan 2019 17:10:06 +0100 (CET) X-Originating-IP: 90.88.147.226 Received: from windsurf (aaubervilliers-681-1-27-226.w90-88.abo.wanadoo.fr [90.88.147.226]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8EC09FF814; Thu, 31 Jan 2019 16:10:03 +0000 (UTC) Date: Thu, 31 Jan 2019 17:10:01 +0100 From: Thomas Petazzoni To: Leigh Brown Cc: linux-arm-kernel@lists.infradead.org, Russell King - ARM Linux admin , =?UTF-8?B?THXDrXM=?= Mendes , linux-pci@vger.kernel.org Subject: Re: Out-of-tree mwlwifi driver crashes Message-ID: <20190131171001.42f181e5@windsurf> In-Reply-To: <3029c89268680e5abe4f073d8247f74d@solinno.co.uk> References: <01e409217be1c1cb08ac3bab072fccd3@solinno.co.uk> <20190129155913.163f1e98@windsurf> <20190129163117.0af2ebb3@windsurf> <8eb5b2981e6e60e91a3eacbb88a5ee7b@solinno.co.uk> <20190131164653.2599d6e7@windsurf> <3029c89268680e5abe4f073d8247f74d@solinno.co.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 31 Jan 2019 16:06:10 +0000 Leigh Brown wrote: > > diff --git a/drivers/pci/pci-bridge-emul.c > > b/drivers/pci/pci-bridge-emul.c > > index 129738362d90..f99b80c19809 100644 > > --- a/drivers/pci/pci-bridge-emul.c > > +++ b/drivers/pci/pci-bridge-emul.c > > @@ -142,11 +142,7 @@ const static struct pci_bridge_reg_behavior > > pci_regs_behavior[] = { > > }, > > > > [PCI_PREF_MEMORY_BASE / 4] = { > > - /* The high 12-bits of pref mem base/limit are RW */ > > - .rw = GENMASK(31, 20) | GENMASK(15, 4), > > - > > - /* The low four bits of pref mem base/limit are RO */ > > - .ro = GENMASK(19, 16) | GENMASK(3, 0), > > + .ro = ~0, > > }, > > > > [PCI_PREF_BASE_UPPER32 / 4] = { > > Thanks for responding. I had to manually apply the patch, but it > certainly fixes the issue. Ah, good to hear this. Let's see if I can find a good fix for this then. Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com