From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCE3C43381 for ; Fri, 15 Feb 2019 20:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16D3D222D7 for ; Fri, 15 Feb 2019 20:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550262053; bh=imvAFOYCm+bMZmqaAO3o1MUjHCUiWgIKsEA/2XAkiIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DRGBUWPTz4nw8Yl0wFxPubNTBa//SNuCeTBGDL2d9nJcBF/yF+phdtUDNGOllnspp uuiXWd2jere9at0t0YIebtn5ZFCtKgy0oNTSbTPpGke1oCU7krjsHoqcH8oQoCiwtY Sr6Ju/7cAkv2gvvF5buiHFq5qffnv4pLdgA5Ig0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732889AbfBOUUw (ORCPT ); Fri, 15 Feb 2019 15:20:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:55784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729429AbfBOUUw (ORCPT ); Fri, 15 Feb 2019 15:20:52 -0500 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6203C222A1; Fri, 15 Feb 2019 20:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550262051; bh=imvAFOYCm+bMZmqaAO3o1MUjHCUiWgIKsEA/2XAkiIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZAsS63CKug6E4B1Bw+dTY5ak4DaH0QYEeKdUYJClPLpSwFnYPlVM/mHl0LdP0ZER 9QmadBX1DzPMAG1nCneAXaOUqzYmVYZKC0tvzIYtUQdNZf4AhrSYrnsas4oZF1Mggm O8X4ekifmtrrJAQhL9IW4zOIXaMFBFSSvtdBKKQI= Date: Fri, 15 Feb 2019 14:20:49 -0600 From: Bjorn Helgaas To: Mika Westerberg Cc: "Rafael J. Wysocki" , Lukas Wunner , Heiner Kallweit , Sinan Kaya , Keith Busch , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot Message-ID: <20190215202049.GT96272@google.com> References: <20190131170746.7604-1-mika.westerberg@linux.intel.com> <20190214212619.GO96272@google.com> <20190215093820.GK2322@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215093820.GK2322@lahna.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Feb 15, 2019 at 11:38:20AM +0200, Mika Westerberg wrote: > On Thu, Feb 14, 2019 at 03:26:19PM -0600, Bjorn Helgaas wrote: > > On Thu, Jan 31, 2019 at 08:07:44PM +0300, Mika Westerberg wrote: > > > Hi all, > > > > > > Heiner reported [1] that runtime PME generation of his network card does > > > not work after commit 0e157e528604 ("PCI/PME: Implement runtime PM > > > callbacks") that landed in v4.20. Reverting the commit helps but it has > > > another drawback, which I originally tried to solve with the commit, that > > > the PCIe hierarchy wakes up immediately after being put into D3cold. > > > > > > This series of two patches tries to fix both issues so that PME wakes up > > > from D3hot and that the hierarchy does not wake up immediately from D3cold. > > > > > > The previous version of the series can be found here: > > > > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1892241.html > > > > > > Changes from the previous version: > > > > > > * Add tags from Heiner and Rafael > > > * Update changelog to mention relevent PCIe spec sections > > > * Add comment to pcie_disable_interrupt() explaining why and what is > > > masked > > > > > > [1] https://www.spinics.net/lists/linux-pci/msg79051.html > > > > > > Mika Westerberg (2): > > > Revert "PCI/PME: Implement runtime PM callbacks" > > > PCI: pciehp: Disable Data Link Layer State Changed event on suspend > > > > I tentatively applied these to pci/pm for v5.1. > > Thanks! > > > I suspect these should be marked for stable (v4.20+)? > > Yes, I think it makes sense. > > > I don't think the bugzilla in the second patch is directly relevant to > > that patch. I'd like to update the patch with a more relevant > > bugzilla if you have or can open one? > > I created a new one and included the link in my reply to the other > patch. I marked both for stable and updated the bugzilla link. Thanks! Bjorn