From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux PCI <linux-pci@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Changbin Du <changbin.du@gmail.com>
Subject: Re: [PATCH v2 25/79] docs: convert docs to ReST and rename to *.rst
Date: Mon, 22 Apr 2019 11:07:54 -0300 [thread overview]
Message-ID: <20190422110754.4d75c5ce@coco.lan> (raw)
In-Reply-To: <CAErSpo4FLuCVPGAZGKeBn=-oyaw6eTrseMnaHJo1TVjxnfCZrw@mail.gmail.com>
Em Mon, 22 Apr 2019 08:48:10 -0500
Bjorn Helgaas <bhelgaas@google.com> escreveu:
> [+cc Changbin, -cc many others]
>
> On Mon, Apr 22, 2019 at 8:28 AM Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org> wrote:
> >
> > Convert the PM documents to ReST, in order to allow them to
> > build with Sphinx.
> >
> > The conversion is actually:
> > - add blank lines and identation in order to identify paragraphs;
>
> s/identation/indentation/
>
> > - fix tables markups;
> > - add some lists markups;
> > - mark literal blocks;
> > - adjust title markups.
> >
> > At its new index.rst, let's add a :orphan: while this is not linked to
> > the main index.rst file, in order to avoid build warnings.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>
> The PCI part of this is fine with me but may conflict with Changbin's work:
>
> https://lore.kernel.org/lkml/20190409155626.6049-1-changbin.du@gmail.com
Yes it could generate a conflict, but it is a trivial change:
--- a/Documentation/PCI/pci.txt
+++ b/Documentation/PCI/pci.txt
@@ -110,7 +110,7 @@ initialization with a pointer to a structure describing the driver
resume_early Wake device from low power state.
resume Wake device from low power state.
- (Please see Documentation/power/pci.txt for descriptions
+ (Please see Documentation/power/pci.rst for descriptions
of PCI Power Management and the related functions.)
shutdown Hook into reboot_notifier_list (kernel/sys.c).
Looking at Changbin's patch 02/12 v3:
https://lore.kernel.org/lkml/20190409155626.6049-3-changbin.du@gmail.com/
It doesn't touch the above line, nor the context lines, and it doesn't
change more than 50% of the file. So, even if this patch gets merged
after the PCI changeset, git will very likely recognize it as a
rename and will apply it anyway.
> Since this doesn't look like it's targeting merge via the PCI tree,
> I'll let you two work out any conflicts.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks!
Mauro
next prev parent reply other threads:[~2019-04-22 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1555938375.git.mchehab+samsung@kernel.org>
2019-04-22 13:27 ` [PATCH v2 26/79] docs: powerpc: convert docs to ReST and rename to *.rst Mauro Carvalho Chehab
2019-04-24 1:15 ` Andrew Donnellan
[not found] ` <7adf9035ae06ecc6c7e46b51cb677f0a8f61d19a.1555938376.git.mchehab+samsung@kernel.org>
2019-04-22 13:48 ` [PATCH v2 25/79] docs: " Bjorn Helgaas
2019-04-22 14:07 ` Mauro Carvalho Chehab [this message]
2019-04-25 18:07 ` Mark Brown
2019-04-26 9:46 ` Mauro Carvalho Chehab
2019-04-27 17:25 ` Mark Brown
2019-04-27 18:13 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422110754.4d75c5ce@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=bhelgaas@google.com \
--cc=changbin.du@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).