From: Benson Leung <bleung@google.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Joerg Roedel" <joro@8bytes.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Paul Mackerras" <paulus@samba.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:AMD KFD" <dri-devel@lists.freedesktop.org>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux-foundation.org>,
"open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER"
<netdev@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id
Date: Thu, 25 Apr 2019 11:21:21 -0700 [thread overview]
Message-ID: <20190425182121.GA175682@google.com> (raw)
In-Reply-To: <e882f58b-0808-952e-d293-5e8cc3f04c97@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
Hi Heiner,
On Wed, Apr 24, 2019 at 09:17:19PM +0200, Heiner Kallweit wrote:
> Use new helper pci_dev_id() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-By: Benson Leung <bleung@chromium.org>
> ---
> drivers/platform/chrome/chromeos_laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
> index 24326eecd..7abbb6167 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -125,7 +125,7 @@ static bool chromeos_laptop_match_adapter_devid(struct device *dev, u32 devid)
> return false;
>
> pdev = to_pci_dev(dev);
> - return devid == PCI_DEVID(pdev->bus->number, pdev->devfn);
> + return devid == pci_dev_id(pdev);
> }
>
> static void chromeos_laptop_check_adapter(struct i2c_adapter *adapter)
> --
> 2.21.0
>
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-25 18:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 19:10 [PATCH v2 0/9] PCI: add help pci_dev_id Heiner Kallweit
2019-04-24 19:11 ` [PATCH v2 1/9] PCI: add helper pci_dev_id Heiner Kallweit
2019-04-24 19:12 ` [PATCH v2 2/9] PCI: use " Heiner Kallweit
2019-04-24 19:13 ` [PATCH v2 3/9] r8169: use new " Heiner Kallweit
2019-04-24 19:14 ` [PATCH v2 4/9] powerpc/powernv/npu: use " Heiner Kallweit
2019-04-26 3:44 ` Alexey Kardashevskiy
2019-04-24 19:14 ` [PATCH v2 5/9] drm/amdkfd: " Heiner Kallweit
2019-04-25 6:57 ` Koenig, Christian
2019-04-24 19:15 ` [PATCH v2 6/9] iommu/amd: " Heiner Kallweit
2019-04-26 13:47 ` Joerg Roedel
2019-04-24 19:16 ` [PATCH v2 7/9] iommu/vt-d: " Heiner Kallweit
2019-04-26 13:47 ` Joerg Roedel
2019-04-24 19:16 ` [PATCH v2 8/9] stmmac: pci: " Heiner Kallweit
2019-04-24 19:17 ` [PATCH v2 9/9] platform/chrome: chromeos_laptop: " Heiner Kallweit
2019-04-25 18:21 ` Benson Leung [this message]
2019-04-29 21:14 ` [PATCH v2 0/9] PCI: add help pci_dev_id Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425182121.GA175682@google.com \
--to=bleung@google.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.torgue@st.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bleung@chromium.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=enric.balletbo@collabora.com \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joabreu@synopsys.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oded.gabbay@gmail.com \
--cc=paulus@samba.org \
--cc=peppe.cavallaro@st.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).