From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DD8C46477 for ; Fri, 14 Jun 2019 06:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB380208CA for ; Fri, 14 Jun 2019 06:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725825AbfFNGrq (ORCPT ); Fri, 14 Jun 2019 02:47:46 -0400 Received: from verein.lst.de ([213.95.11.211]:44512 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbfFNGrq (ORCPT ); Fri, 14 Jun 2019 02:47:46 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id CC60468B02; Fri, 14 Jun 2019 08:47:16 +0200 (CEST) Date: Fri, 14 Jun 2019 08:47:16 +0200 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-nvdimm@lists.01.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 21/22] mm: remove the HMM config option Message-ID: <20190614064716.GN7246@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-22-hch@lst.de> <20190613200150.GB22062@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613200150.GB22062@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jun 13, 2019 at 08:01:55PM +0000, Jason Gunthorpe wrote: > On Thu, Jun 13, 2019 at 11:43:24AM +0200, Christoph Hellwig wrote: > > All the mm/hmm.c code is better keyed off HMM_MIRROR. Also let nouveau > > depend on it instead of the mix of a dummy dependency symbol plus the > > actually selected one. Drop various odd dependencies, as the code is > > pretty portable. > > I don't really know, but I thought this needed the arch restriction > for the same reason get_user_pages has various unique arch specific > implementations (it does seem to have some open coded GUP like thing)? > > I was hoping we could do this after your common gup series? But sooner > is better too. Ok, I've added the arch and 64-bit dependency back in for now. It does not look proper to me, and is certainly underdocumented, but the whole pagetable walking code will need a lot of love eventually anyway, and the Kconfig stuff for it can be done properly then.