Re: [PATCH 07/22] memremap: move dev_pagemap callbacks into a separate structure

Logan Gunthorpe
2019-06-13T20:15:03Z

On 2019-06-13 3:43 a.m., Christoph Hellwig wrote:
> The dev_pagemap is a growing too many callbacks. Move them into a
> separate ops structure so that they are not duplicated for multiple
> instances, and an attacker can't easily overwrite them.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/dax/device.c | 6 +++++-
> drivers/nvdimm/pmem.c | 18 +++++++++++++-----
> drivers/pci/p2pdma.c | 5 ++++-
> include/linux/memremap.h | 29 +++++++++++++++--------------
> kernel/memremap.c | 12 ++++++------
> mm/hmm.c | 8 ++++++--
> tools/testing/nvdimm/test/iomap.c | 2 +-
> 7 files changed, 50 insertions(+), 30 deletions(-)

Looks good to me,

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Logan