Re: [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

Christoph Hellwig
2019-06-15T14:31:15Z

On Fri, Jun 14, 2019 at 07:21:54PM -0700, John Hubbard wrote:
> On 6/13/19 2:43 AM, Christoph Hellwig wrote:
> > Keep the physical address allocation that hmm_add_device does with the
> > rest of the resource code, and allow future reuse of it without the hmm
> > wrapper.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > include/linux/ioport.h | 2 ++
> > kernel/resource.c | 39 +++++++++++++++++++++++++++++++++++++++
> > mm/hmm.c | 33 ++++-----------------------------
> > 3 files changed, 45 insertions(+), 29 deletions(-)
>
> Some trivial typos noted below, but this accurately moves the code
> into a helper routine, looks good.

Thanks for the typo spotting. These two actually were copy and pasted
from the original hmm code, but I'll gladly fix them for the next
iteration.