Re: [PATCH 17/22] mm: remove hmm_devmem_add

Jason Gunthorpe
2019-06-13T19:42:49Z

On Thu, Jun 13, 2019 at 11:43:20AM +0200, Christoph Hellwig wrote:
> There isn't really much value add in the hmm_devmem_add wrapper. Just
> factor out a little helper to find the resource, and otherwise let the
> driver implement the dev_pagemap_ops directly.

Was this commit message written when other patches were squashed in
here? I think the helper this mentions was from an earlier patch

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/vm/hmm.rst | 26 --------
> include/linux/hmm.h | 129 ---------------------------------------
> mm/hmm.c | 115 ----------------------------------
> 3 files changed, 270 deletions(-)

I looked for in-flight patches that might be using these APIs and
found nothing. To be sent patches can use the new API with no loss in
functionality...

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Jason