Re: [PATCH 08/22] memremap: pass a struct dev_pagemap to ->kill

Jason Gunthorpe
2019-06-13T19:26:25Z

On Thu, Jun 13, 2019 at 11:43:11AM +0200, Christoph Hellwig wrote:
> Passing the actual typed structure leads to more understandable code
> vs the actual references.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> drivers/dax/device.c | 7 +++----
> drivers/nvdimm/pmem.c | 6 +++---
> drivers/pci/p2pdma.c | 6 +++---
> include/linux/memremap.h | 2 +-
> kernel/memremap.c | 4 ++--
> mm/hmm.c | 4 ++--
> tools/testing/nvdimm/test/iomap.c | 6 ++----
> 7 files changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
> index 4adab774dade..e23fa1bd8c97 100644
> +++ b/drivers/dax/device.c
> @@ -37,13 +37,12 @@ static void dev_dax_percpu_exit(void *data)
> percpu_ref_exit(ref);
> }
>
> -static void dev_dax_percpu_kill(struct percpu_ref *data)
> +static void dev_dax_percpu_kill(struct dev_pagemap *pgmap)
> {

Looks like it was always like this, but I also can't see a reason to
use the percpu as a handle for a dev_pagemap callback.

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Jason