From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD23C31E49 for ; Sun, 16 Jun 2019 08:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9682216C8 for ; Sun, 16 Jun 2019 08:00:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725992AbfFPIAY (ORCPT ); Sun, 16 Jun 2019 04:00:24 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47785 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbfFPIAX (ORCPT ); Sun, 16 Jun 2019 04:00:23 -0400 X-Originating-IP: 213.174.99.131 Received: from windsurf (smb-adpcdg1-03.hotspot.hub-one.net [213.174.99.131]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 783771C0006; Sun, 16 Jun 2019 08:00:19 +0000 (UTC) Date: Sun, 16 Jun 2019 10:00:17 +0200 From: Thomas Petazzoni To: Miquel Raynal Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: armada8k: Add PHYs support Message-ID: <20190616100017.607e4848@windsurf> In-Reply-To: <20190401131239.17008-1-miquel.raynal@bootlin.com> References: <20190401131239.17008-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hello, On Mon, 1 Apr 2019 15:12:39 +0200 Miquel Raynal wrote: > Bring PHY support for the Armada8k driver. > > The Armada8k IP only supports x1, x2 or x4 link widths. Iterate over > the DT 'phys' entries and configure them one by one. Use > phy_set_mode_ext() to make use of the submode parameter (initially > introduced for Ethernet modes). For PCI configuration, let the submode > be the width (1, 2, 4, etc) so that the PHY driver knows how many > lanes are bundled. Do not error out in case of error for compatibility > reasons. > > Signed-off-by: Miquel Raynal Reviewed-by: Thomas Petazzoni Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com