From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-pci@vger.kernel.org,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: [PATCH v1 1/2] tools: PCI: Fix compilation error
Date: Fri, 28 Jun 2019 16:12:17 +0300 [thread overview]
Message-ID: <20190628131218.10244-1-andriy.shevchenko@linux.intel.com> (raw)
The commit
b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
forgot to update function prototype and thus brought a regression:
pcitest.c:221:9: error: void value not ignored as it ought to be
return run_test(test);
^~~~~~~~~~~~~~
Fix it by changing prototype from void to int.
While here, initialize ret with 0 to avoid compiler warning:
pcitest.c:132:25: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Fixes: b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
tools/pci/pcitest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index cb7a47dfd8b6..81b89260e80f 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -36,15 +36,15 @@ struct pci_test {
unsigned long size;
};
-static void run_test(struct pci_test *test)
+static int run_test(struct pci_test *test)
{
- long ret;
+ long ret = 0;
int fd;
fd = open(test->device, O_RDWR);
if (fd < 0) {
perror("can't open PCI Endpoint Test device");
- return;
+ return fd;
}
if (test->barnum >= 0 && test->barnum <= 5) {
@@ -129,7 +129,7 @@ static void run_test(struct pci_test *test)
}
fflush(stdout);
- return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
+ return (ret < 0) ? ret : 0; /* return 0 if test succeeded */
}
int main(int argc, char **argv)
--
2.20.1
next reply other threads:[~2019-06-28 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 13:12 Andy Shevchenko [this message]
2019-06-28 13:12 ` [PATCH v1 2/2] tools: PCI: Fix a typo in usage messages Andy Shevchenko
2019-07-05 13:34 ` [PATCH v1 1/2] tools: PCI: Fix compilation error Lorenzo Pieralisi
2019-07-05 14:21 ` Andy Shevchenko
2019-07-05 15:04 ` Lorenzo Pieralisi
2019-07-05 15:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628131218.10244-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jjhiblot@ti.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox