From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-pci@vger.kernel.org,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: [PATCH v1 2/2] tools: PCI: Fix a typo in usage messages
Date: Fri, 28 Jun 2019 16:12:18 +0300 [thread overview]
Message-ID: <20190628131218.10244-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190628131218.10244-1-andriy.shevchenko@linux.intel.com>
When the commit fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
introduced a fix to support -h command line option, it, at the same time,
brought a regression to the code which produces a compile-time warning:
pcitest.c:203:4: warning: too many arguments for format [-Wformat-extra-args]
"usage: %s [options]\n"
^~~~~~~~~~~~~~~~~~~~~~~
Remove trailing comma to make it correct.
Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
tools/pci/pcitest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 81b89260e80f..c495e5b5fd7f 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -212,7 +212,7 @@ int main(int argc, char **argv)
"\t-r Read buffer test\n"
"\t-w Write buffer test\n"
"\t-c Copy buffer test\n"
- "\t-s <size> Size of buffer {default: 100KB}\n",
+ "\t-s <size> Size of buffer {default: 100KB}\n"
"\t-h Print this help message\n",
argv[0]);
return -EINVAL;
--
2.20.1
next prev parent reply other threads:[~2019-06-28 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 13:12 [PATCH v1 1/2] tools: PCI: Fix compilation error Andy Shevchenko
2019-06-28 13:12 ` Andy Shevchenko [this message]
2019-07-05 13:34 ` Lorenzo Pieralisi
2019-07-05 14:21 ` Andy Shevchenko
2019-07-05 15:04 ` Lorenzo Pieralisi
2019-07-05 15:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628131218.10244-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox