From: Bjorn Helgaas <helgaas@kernel.org>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: Logan Gunthorpe <logang@deltatee.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Multitude of resource assignment functions
Date: Tue, 2 Jul 2019 16:39:51 -0500 [thread overview]
Message-ID: <20190702213951.GF128603@google.com> (raw)
In-Reply-To: <SL2P216MB0187E659CFF6F9385E92838680FE0@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
On Sun, Jun 30, 2019 at 02:57:37AM +0000, Nicholas Johnson wrote:
> - Should pci=noacpi imply pci=nocrs? It does not appear to, and I feel
> like it should, as CRS is part of ACPI and relates to PCI.
"pci=noacpi" means "Do not use ACPI for IRQ routing or for PCI
scanning."
"pci=nocrs" means "Ignore PCI host bridge windows from ACPI." If we
ignore _CRS, we have no idea what the PCI host bridge apertures are,
so we cannot allocate resources for devices on the root bus.
The "Do not use ACPI for ... PCI scanning" part indeed does suggest
that "pci=noacpi" could imply "pci=nocrs", but I don't think there's
anything to be gained by changing that now.
We probably *should* remove "or for PCI scanning" from the
documentation, because "pci=noacpi" only affects IRQs.
The only reason these exist at all is as a debugging aid to
temporarily work around issues in firmware or Linux until we can
develop a real fix or quirk that works without the user specifying a
kernel parameter.
> - Does anybody know why with pci=noacpi, you get dmesg warnings about
> cannot find PCI int A mapping - but they do not seem to cause the
> devices any issues in functioning? Is it because they are using MSI?
I doubt it. I think you're just lucky. In general the information
from _PRT and _CRS is essential for correct operation.
> - Does pci=ignorefw sound good for a future proposal?
No, at least not without more description of what this would
accomplish.
It sounds like you would want this to turn off _PRT, _CRS, and other
information from ACPI. You may not like ACPI, but that information is
there for good reason, and if we didn't get it from ACPI we would have
to get it from somewhere else.
There is always "acpi=off" if you just don't want ACPI at all.
Bjorn
next prev parent reply other threads:[~2019-07-03 1:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SL2P216MB01874DFDDBDE49B935A9B1B380E50@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
2019-06-19 16:21 ` [nicholas.johnson-opensource@outlook.com.au: [PATCH v6 3/4] PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window] Logan Gunthorpe
2019-06-20 0:44 ` Nicholas Johnson
2019-06-20 0:49 ` Logan Gunthorpe
2019-06-23 5:01 ` Nicholas Johnson
2019-06-24 9:13 ` Multitude of resource assignment functions Benjamin Herrenschmidt
2019-06-24 16:45 ` Logan Gunthorpe
2019-06-27 7:40 ` Nicholas Johnson
2019-06-27 8:48 ` Benjamin Herrenschmidt
2019-06-30 2:40 ` Nicholas Johnson
2019-06-27 16:35 ` Logan Gunthorpe
2019-06-27 20:26 ` Benjamin Herrenschmidt
2019-06-30 2:57 ` Nicholas Johnson
2019-07-01 4:33 ` Oliver O'Halloran
2019-07-02 21:39 ` Bjorn Helgaas [this message]
2019-07-03 13:43 ` Nicholas Johnson
2019-07-03 14:19 ` Bjorn Helgaas
2019-07-03 22:54 ` Benjamin Herrenschmidt
2019-06-20 13:43 ` [nicholas.johnson-opensource@outlook.com.au: [PATCH v6 3/4] PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window] Bjorn Helgaas
2019-06-20 23:24 ` Benjamin Herrenschmidt
2019-06-27 7:50 ` Nicholas Johnson
2019-06-27 16:54 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702213951.GF128603@google.com \
--to=helgaas@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).