From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v1 1/2] tools: PCI: Fix compilation error
Date: Fri, 5 Jul 2019 17:21:47 +0300 [thread overview]
Message-ID: <20190705142147.GE9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190705133441.GA31464@e121166-lin.cambridge.arm.com>
On Fri, Jul 05, 2019 at 02:34:41PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Jun 28, 2019 at 04:12:17PM +0300, Andy Shevchenko wrote:
> > The commit
> >
> > b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
> >
> > forgot to update function prototype and thus brought a regression:
> >
> > pcitest.c:221:9: error: void value not ignored as it ought to be
> > return run_test(test);
> > ^~~~~~~~~~~~~~
> >
> > Fix it by changing prototype from void to int.
> >
> > While here, initialize ret with 0 to avoid compiler warning:
> >
> > pcitest.c:132:25: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > Fixes: b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
> > Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > tools/pci/pcitest.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Patch 1 and 2 already applied from another thread:
>
> https://lore.kernel.org/linux-pci/1558646281-12676-1-git-send-email-alan.mikhak@sifive.com/
>
> Thanks anyway !
I don't see neither in v5.2-rc7, nor in Linux Next.
In which repository is it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-07-05 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 13:12 [PATCH v1 1/2] tools: PCI: Fix compilation error Andy Shevchenko
2019-06-28 13:12 ` [PATCH v1 2/2] tools: PCI: Fix a typo in usage messages Andy Shevchenko
2019-07-05 13:34 ` [PATCH v1 1/2] tools: PCI: Fix compilation error Lorenzo Pieralisi
2019-07-05 14:21 ` Andy Shevchenko [this message]
2019-07-05 15:04 ` Lorenzo Pieralisi
2019-07-05 15:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705142147.GE9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jjhiblot@ti.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox