From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5839DC46499 for ; Fri, 5 Jul 2019 15:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D6B21852 for ; Fri, 5 Jul 2019 15:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725882AbfGEPtm (ORCPT ); Fri, 5 Jul 2019 11:49:42 -0400 Received: from mga03.intel.com ([134.134.136.65]:46926 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbfGEPtm (ORCPT ); Fri, 5 Jul 2019 11:49:42 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 08:49:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,455,1557212400"; d="scan'208";a="363626325" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga006.fm.intel.com with ESMTP; 05 Jul 2019 08:49:14 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hjQSX-0002MN-TU; Fri, 05 Jul 2019 18:49:13 +0300 Date: Fri, 5 Jul 2019 18:49:13 +0300 From: Andy Shevchenko To: Lorenzo Pieralisi Cc: linux-pci@vger.kernel.org, Gustavo Pimentel , Jean-Jacques Hiblot , Kishon Vijay Abraham I Subject: Re: [PATCH v1 1/2] tools: PCI: Fix compilation error Message-ID: <20190705154913.GF9224@smile.fi.intel.com> References: <20190628131218.10244-1-andriy.shevchenko@linux.intel.com> <20190705133441.GA31464@e121166-lin.cambridge.arm.com> <20190705142147.GE9224@smile.fi.intel.com> <20190705150412.GC31464@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190705150412.GC31464@e121166-lin.cambridge.arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jul 05, 2019 at 04:04:12PM +0100, Lorenzo Pieralisi wrote: > On Fri, Jul 05, 2019 at 05:21:47PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 05, 2019 at 02:34:41PM +0100, Lorenzo Pieralisi wrote: > > > On Fri, Jun 28, 2019 at 04:12:17PM +0300, Andy Shevchenko wrote: > > > > The commit > > > > > > > > b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails") > > > > > > > > forgot to update function prototype and thus brought a regression: > > > > > > > > pcitest.c:221:9: error: void value not ignored as it ought to be > > > > return run_test(test); > > > > ^~~~~~~~~~~~~~ > > > > > > > > Fix it by changing prototype from void to int. > > > > > > > > While here, initialize ret with 0 to avoid compiler warning: > > > > > > > > pcitest.c:132:25: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > > > > > > > Fixes: b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails") > > > > Cc: Jean-Jacques Hiblot > > > > Cc: Lorenzo Pieralisi > > > > Cc: Kishon Vijay Abraham I > > > > Signed-off-by: Andy Shevchenko > > > > --- > > > > tools/pci/pcitest.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > Patch 1 and 2 already applied from another thread: > > > > > > https://lore.kernel.org/linux-pci/1558646281-12676-1-git-send-email-alan.mikhak@sifive.com/ > > > > > > Thanks anyway ! > > > > I don't see neither in v5.2-rc7, nor in Linux Next. > > In which repository is it? > > It is in -next: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/tools/pci/pcitest.c?h=next-20190705 Ah, thanks. It seems I forgot to update my local branch. -- With Best Regards, Andy Shevchenko