From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ED4BC742A7 for ; Sat, 13 Jul 2019 15:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B78020850 for ; Sat, 13 Jul 2019 15:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563030237; bh=rhgzDBUt9BwMxq+kcRcec6QPbDI11qibjcUAURXIaPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kPuI0cHAXIng9E2BxyhgdN22Ly6yBDBAZITu6F4smVIrHL5NJTrXlhkZ/0pKEAsPM OuxKsUGlM7ndeygkOuoSg2Ce/8uUr9f79BPof9ykBdCjCK7j47bma3QxVsB++Zzczj Zzg3yEyIbh8t4Vl+mxwyBWRlmAHf/mLdoq7kAFsg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfGMPD4 (ORCPT ); Sat, 13 Jul 2019 11:03:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:50396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727626AbfGMPD4 (ORCPT ); Sat, 13 Jul 2019 11:03:56 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C832F20830; Sat, 13 Jul 2019 15:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563030235; bh=rhgzDBUt9BwMxq+kcRcec6QPbDI11qibjcUAURXIaPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WPt6oRaJ5kTRyGlNDrlZ/GflHZ4spBWudBFrnHFoXTH3eRJpAHq9wU02ulORAnSPn r1bn+A0jfbR15ra+hVS2N2gQSBz7uM8iERiEtO3sXaYczPMU/yYdWF3gHn4p2QysR4 U5ennukmaVUWYktXX6S31jWL3IH6lWCZYgVZ7zfQ= Date: Sat, 13 Jul 2019 11:03:53 -0400 From: Sasha Levin To: Haiyang Zhang Cc: Randy Dunlap , linux-pci , LKML , Matthew Wilcox , Jake Oshins , KY Srinivasan , Stephen Hemminger , Stephen Hemminger , Bjorn Helgaas , Dexuan Cui Subject: Re: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config Message-ID: <20190713150353.GF10104@sasha-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jul 12, 2019 at 04:04:17PM +0000, Haiyang Zhang wrote: > > >> -----Original Message----- >> From: Randy Dunlap >> Sent: Friday, July 12, 2019 11:53 AM >> To: linux-pci ; LKML > kernel@vger.kernel.org> >> Cc: Matthew Wilcox ; Jake Oshins >> ; KY Srinivasan ; Haiyang >> Zhang ; Stephen Hemminger >> ; Stephen Hemminger >> ; Sasha Levin ; Bjorn >> Helgaas ; Dexuan Cui >> Subject: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config >> >> From: Randy Dunlap >> >> Fix build errors when building almost-allmodconfig but with SYSFS >> not set (not enabled). Fixes these build errors: >> >> ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! >> ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! >> >> drivers/pci/slot.o is only built when SYSFS is enabled, so >> pci-hyperv.o has an implicit dependency on SYSFS. >> Make that explicit. >> >> Also, depending on X86 && X86_64 is not needed, so just change that >> to depend on X86_64. >> >> Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot >> information") >> >> Signed-off-by: Randy Dunlap >> Cc: Matthew Wilcox >> Cc: Jake Oshins >> Cc: "K. Y. Srinivasan" >> Cc: Haiyang Zhang >> Cc: Stephen Hemminger >> Cc: Stephen Hemminger >> Cc: Sasha Levin >> Cc: Bjorn Helgaas >> Cc: linux-pci@vger.kernel.org >> Cc: linux-hyperv@vger.kernel.org >> Cc: Dexuan Cui >> --- >> v3: corrected Fixes: tag [Dexuan Cui ] >> This is the Microsoft-preferred version of the patch. >> >> drivers/pci/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- lnx-52.orig/drivers/pci/Kconfig >> +++ lnx-52/drivers/pci/Kconfig >> @@ -181,7 +181,7 @@ config PCI_LABEL >> >> config PCI_HYPERV >> tristate "Hyper-V PCI Frontend" >> - depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN >> && X86_64 >> + depends on X86_64 && HYPERV && PCI_MSI && >> PCI_MSI_IRQ_DOMAIN && SYSFS >> help >> The PCI device frontend driver allows the kernel to import arbitrary >> PCI devices from a PCI backend to support PCI driver domains. >> > >Reviewed-by: Haiyang Zhang Queued up for hyperv-fixes, thank you! -- Thanks, Sasha