From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E63EC76186 for ; Tue, 23 Jul 2019 23:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CFD82253D for ; Tue, 23 Jul 2019 23:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563925015; bh=BuegP/V0qI4Z8kyW9R7aYMJWkIoqBWoCJg3WJV3ANEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BrhA0l7aV33ik7VDTPbuYSu2YQRJ8ZBufEUtIyILGzqllm7Jro/rgpFT11RThcvEN mhKZWgf1Dd03NkKo0BypsnybedFZ3r7M3y6Ef7et7/4J0Ls3179xdz4xV2+1CU4CaJ Jtr92P24JDfDVzjnniroAmvY8/5LxBYIbZGyLayg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbfGWXgy (ORCPT ); Tue, 23 Jul 2019 19:36:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:50830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbfGWXgy (ORCPT ); Tue, 23 Jul 2019 19:36:54 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F58B2184B; Tue, 23 Jul 2019 23:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563925013; bh=BuegP/V0qI4Z8kyW9R7aYMJWkIoqBWoCJg3WJV3ANEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEwrrwf7oydOanm0eePwlZFoYfow+Bm7AmlWOdxbHKfMLZE1v6M+hHx5AW70qzZyf i3SaBy7lGtnn6tCVBp06LXAuJ2E6k4I6/7N+02PGSqdL6ZU+KOj2KF0079UKfYNPjH jR3vUvCApW37szj2/TNaOIGsO9NJInHAFh3bjLmU= Date: Tue, 23 Jul 2019 18:36:51 -0500 From: Bjorn Helgaas To: Kelsey Skunberg Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Greg KH Subject: Re: [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c Message-ID: <20190723233651.GD47047@google.com> References: <20190717182353.45557-1-skunberg.kelsey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190717182353.45557-1-skunberg.kelsey@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Greg] On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote: > pci_bus_get() and pci_bus_put() are not used by a loadable kernel module > and do not need to be exported. Remove lines exporting pci_bus_get() and > pci_bus_put(). > > Functions were exported in commit fe830ef62ac6 ("PCI: Introduce > pci_bus_{get|put}() to manage PCI bus reference count"). No found history > of functions being used by a loadable kernel module. > > Signed-off-by: Kelsey Skunberg Applied with Greg's ack to pci/hide for v5.4, thanks! > --- > drivers/pci/bus.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > index 495059d923f7..8e40b3e6da77 100644 > --- a/drivers/pci/bus.c > +++ b/drivers/pci/bus.c > @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus) > get_device(&bus->dev); > return bus; > } > -EXPORT_SYMBOL(pci_bus_get); > > void pci_bus_put(struct pci_bus *bus) > { > if (bus) > put_device(&bus->dev); > } > -EXPORT_SYMBOL(pci_bus_put); > -- > 2.20.1 > > _______________________________________________ > Linux-kernel-mentees mailing list > Linux-kernel-mentees@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees