From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACEDC0650F for ; Thu, 8 Aug 2019 19:55:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F5092184E for ; Thu, 8 Aug 2019 19:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565294149; bh=SOl9abd2o/Qj2dBjH8ebZDl44aPBVBw4i1AVCjPY/nM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sZqV7BwWtfgq2XDCVfbfvOiLj+rflgISiJhZseNoZIY29k6G9BRYPTFoeS++4JhFm 3sECaATlui84yKfUSgQe1rch20mAcd/yc+1v9WPsgiOp/k2NnD5J8qII/rI6XNmooF Ug8iD9+ZPnV+1dGs57YZmkdFbZgQrSvyYNj2+frw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390202AbfHHTzt (ORCPT ); Thu, 8 Aug 2019 15:55:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:59186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403831AbfHHTzs (ORCPT ); Thu, 8 Aug 2019 15:55:48 -0400 Received: from localhost (unknown [150.199.191.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFF27214C6; Thu, 8 Aug 2019 19:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565294148; bh=SOl9abd2o/Qj2dBjH8ebZDl44aPBVBw4i1AVCjPY/nM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bcSQCIe8/dBRIW/bkZwTbBcOfWJ4jURkIhZlfAMVQPFrM5ExqBnMoMiU+OZP22HmH qtNCe2+K6MFBvvpcNJEji2ZB4Sedflcze8rLCZwt8trL2tmqUQ7s/NOAENdW8FKmls tkkXDZVEmglLE30DV31AOWoNN5GLRLau9OtaXi+g= Date: Thu, 8 Aug 2019 14:55:46 -0500 From: Bjorn Helgaas To: Paul Walmsley Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Wesley Terpstra Subject: Re: [PATCH v2] pci: Kconfig: select PCI_MSI_IRQ_DOMAIN by default on RISC-V Message-ID: <20190808195546.GA7302@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Paul, Wesley, On Thu, Jul 25, 2019 at 02:28:07PM -0700, Paul Walmsley wrote: > From: Wesley Terpstra > > This is part of adding support for RISC-V systems with PCIe host > controllers that support message-signaled interrupts. > > Signed-off-by: Wesley Terpstra > [paul.walmsley@sifive.com: wrote patch description; split this > patch from the arch/riscv patch] > Signed-off-by: Paul Walmsley > --- > drivers/pci/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > index 2ab92409210a..beb3408a0272 100644 > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -52,7 +52,7 @@ config PCI_MSI > If you don't know what to do here, say Y. > > config PCI_MSI_IRQ_DOMAIN > - def_bool ARC || ARM || ARM64 || X86 > + def_bool ARC || ARM || ARM64 || X86 || RISCV The other arches listed here either supply their own include/asm/msi.h or generate it: $ ls arch/*/include/asm/msi.h arch/x86/include/asm/msi.h $ grep msi.h arch/*/include/asm/Kbuild arch/arc/include/asm/Kbuild:generic-y += msi.h arch/arm64/include/asm/Kbuild:generic-y += msi.h arch/arm/include/asm/Kbuild:generic-y += msi.h arch/mips/include/asm/Kbuild:generic-y += msi.h arch/powerpc/include/asm/Kbuild:generic-y += msi.h arch/sparc/include/asm/Kbuild:generic-y += msi.h For example, see f8430eae9f1b ("PCI/MSI: Enable PCI_MSI_IRQ_DOMAIN support for ARC") be091d468a0a ("arm64: PCI/MSI: Use asm-generic/msi.h") 0ab089c2548c ("ARM: Add msi.h to Kbuild") I didn't look into the details of msi.h generation, but I assume RISC-V needs to do something similar? If so, I think that should be part of this patch to avoid issues. If CONFIG_GENERIC_MSI_IRQ_DOMAIN is defined, include/linux/msi.h #includes and I don't see where that would come from. > depends on PCI_MSI > select GENERIC_MSI_IRQ_DOMAIN Bjorn