From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5510C3A589 for ; Tue, 20 Aug 2019 09:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AA5222CF5 for ; Tue, 20 Aug 2019 09:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729291AbfHTJeV (ORCPT ); Tue, 20 Aug 2019 05:34:21 -0400 Received: from foss.arm.com ([217.140.110.172]:37328 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729194AbfHTJeU (ORCPT ); Tue, 20 Aug 2019 05:34:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C41A344; Tue, 20 Aug 2019 02:34:18 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE45A3F706; Tue, 20 Aug 2019 02:34:17 -0700 (PDT) Date: Tue, 20 Aug 2019 10:34:16 +0100 From: Andrew Murray To: Krzysztof Wilczynski Cc: Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/PCI: Remove surplus return from a void function Message-ID: <20190820093415.GF23903@e119886-lin.cambridge.arm.com> References: <20190820065121.16594-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820065121.16594-1-kw@linux.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Aug 20, 2019 at 08:51:21AM +0200, Krzysztof Wilczynski wrote: > Remove unnecessary empty return statement at the end of a void > function in the arch/x86/kernel/quirks.c. > > Signed-off-by: Krzysztof Wilczynski > --- > arch/x86/kernel/quirks.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c > index 8451f38ad399..1daf8f2aa21f 100644 > --- a/arch/x86/kernel/quirks.c > +++ b/arch/x86/kernel/quirks.c > @@ -90,8 +90,6 @@ static void ich_force_hpet_resume(void) > BUG(); > else > printk(KERN_DEBUG "Force enabled HPET at resume\n"); > - > - return; > } > > static void ich_force_enable_hpet(struct pci_dev *dev) > @@ -448,7 +446,6 @@ static void nvidia_force_enable_hpet(struct pci_dev *dev) > dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at 0x%lx\n", > force_hpet_address); > cached_dev = dev; > - return; > } > > /* ISA Bridges */ > @@ -513,7 +510,6 @@ static void e6xx_force_enable_hpet(struct pci_dev *dev) > force_hpet_resume_type = NONE_FORCE_HPET_RESUME; > dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at " > "0x%lx\n", force_hpet_address); > - return; > } > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E6XX_CU, > e6xx_force_enable_hpet); > -- Reviewed-by: Andrew Murray > 2.22.1 >