From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD4BC3A5A1 for ; Wed, 28 Aug 2019 21:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55AA722CED for ; Wed, 28 Aug 2019 21:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbfH1VI6 (ORCPT ); Wed, 28 Aug 2019 17:08:58 -0400 Received: from foss.arm.com ([217.140.110.172]:36362 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfH1VI6 (ORCPT ); Wed, 28 Aug 2019 17:08:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 122A9337; Wed, 28 Aug 2019 14:08:58 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8496A3F718; Wed, 28 Aug 2019 14:08:56 -0700 (PDT) Date: Wed, 28 Aug 2019 22:08:55 +0100 From: Andrew Murray To: Thierry Reding Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, Jingoo Han , Kukjin Kim , Krzysztof Kozlowski Subject: Re: [PATCH 1/5] PCI: exynos: Properly handle optional PHYs Message-ID: <20190828210854.GC14582@e119886-lin.cambridge.arm.com> References: <20190828163636.12967-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828163636.12967-1-thierry.reding@gmail.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Aug 28, 2019 at 06:36:32PM +0200, Thierry Reding wrote: > From: Thierry Reding > > devm_of_phy_get() can fail for a number of resides besides probe > deferral. It can for example return -ENOMEM if it runs out of memory as > it tries to allocate devres structures. Propagating only -EPROBE_DEFER > is problematic because it results in these legitimately fatal errors > being treated as "PHY not specified in DT". > > What we really want is to ignore the optional PHYs only if they have not > been specified in DT. devm_of_phy_get() returns -ENODEV in this case, so > that's the special case that we need to handle. So we propagate all > errors, except -ENODEV, so that real failures will still cause the > driver to fail probe. > > Cc: Jingoo Han > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Thierry Reding > --- > drivers/pci/controller/dwc/pci-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c > index cee5f2f590e2..14a6ba4067fb 100644 > --- a/drivers/pci/controller/dwc/pci-exynos.c > +++ b/drivers/pci/controller/dwc/pci-exynos.c > @@ -465,7 +465,7 @@ static int __init exynos_pcie_probe(struct platform_device *pdev) > > ep->phy = devm_of_phy_get(dev, np, NULL); > if (IS_ERR(ep->phy)) { > - if (PTR_ERR(ep->phy) == -EPROBE_DEFER) > + if (PTR_ERR(ep->phy) != -ENODEV) > return PTR_ERR(ep->phy); > > ep->phy = NULL; Once you've applied Bjorn's feedback you can add: Reviewed-by: Andrew Murray > -- > 2.22.0 >