From: Remi Pommarel <repk@triplefau.lt>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Yue Wang <yue.wang@amlogic.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] PCI: amlogic: Fix reset assertion via gpio descriptor
Date: Mon, 2 Sep 2019 16:43:07 +0200 [thread overview]
Message-ID: <20190902144306.GA1011@voidbox.localdomain> (raw)
In-Reply-To: <20190902105536.GG9720@e119886-lin.cambridge.arm.com>
On Mon, Sep 02, 2019 at 11:55:36AM +0100, Andrew Murray wrote:
> On Sun, Sep 01, 2019 at 03:39:15PM +0200, Remi Pommarel wrote:
> > Normally asserting reset signal on gpio would be achieved with:
> > gpiod_set_value_cansleep(reset_gpio, 1);
> >
> > Meson PCI driver set reset value to '0' instead of '1' as it takes into
> > account the PERST# signal polarity. The polarity should be taken care
> > in the device tree instead.
> >
> > This fixes the reset assertion meaning and moves out the polarity
> > configuration in DT (please note that there is no DT currently using
> > this driver).
>
> The device tree bindings for this give an example configuration:
>
> pcie: pcie@f9800000 {
> compatible = "amlogic,axg-pcie", "snps,dw-pcie";
> reg = <0x0 0xf9800000 0x0 0x400000
> 0x0 0xff646000 0x0 0x2000
> 0x0 0xff644000 0x0 0x2000
> 0x0 0xf9f00000 0x0 0x100000>;
> reg-names = "elbi", "cfg", "phy", "config";
> reset-gpios = <&gpio GPIOX_19 GPIO_ACTIVE_HIGH>;
>
> Is the 'reset-gpios' line still consistent with this change, or does
> this need to be updated as well?
Good catch, the polarity of the reset gpio will more likely be
GPIO_ACTIVE_LOW.
Do you want a separate patch for that or can I just include it in v2 ?
Thanks.
--
Remi
next prev parent reply other threads:[~2019-09-02 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 13:39 [PATCH] PCI: amlogic: Fix reset assertion via gpio descriptor Remi Pommarel
2019-09-01 21:46 ` Martin Blumenstingl
2019-09-02 8:11 ` Neil Armstrong
2019-09-02 10:55 ` Andrew Murray
2019-09-02 14:43 ` Remi Pommarel [this message]
2019-09-02 22:34 ` Martin Blumenstingl
2019-10-15 14:02 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902144306.GA1011@voidbox.localdomain \
--to=repk@triplefau.lt \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).