From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 032D7C388F4 for ; Fri, 27 Sep 2019 12:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C409E21BE5 for ; Fri, 27 Sep 2019 12:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569588899; bh=w3XEylaO3Qc+K7bAJgMP04bk+svHue7waGNxI0le2lw=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=pe5zF0Fz8D2QlHZGSC5Bsm69F3GqhDTMznmg1A+6zurD/VwkEIFpVrj/oYoecyCPW b1vBkYW4ZXGvJvKSQ++y8BaYPWeUbVG3xVSIjGog7qBp90B/xrGwkqcp8mwfCFvqZ8 GVHWCH4kRuZPaDRrnNozAG868glaC7MAc9EkUXZc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbfI0My7 (ORCPT ); Fri, 27 Sep 2019 08:54:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:55986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbfI0My6 (ORCPT ); Fri, 27 Sep 2019 08:54:58 -0400 Received: from localhost (173-25-179-30.client.mchsi.com [173.25.179.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1207520872; Fri, 27 Sep 2019 12:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569588898; bh=w3XEylaO3Qc+K7bAJgMP04bk+svHue7waGNxI0le2lw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=195lv9RzhoE+bN696fHGZIL9z0prRuuLIdJ0HNFPsg2Xr1bguxTlr/QqlNVTu8FYr Ym6ur319dPtAMsK8g4vzeJ6CRFM4P1qkBtzi9Yjr+lJNaeIW0AaWETieAgq7O1/9u3 sYZ5HBltvUCLbiqmgFm1tpSseNK7ZhLdBx5p1cWc= Date: Fri, 27 Sep 2019 07:54:57 -0500 From: Bjorn Helgaas To: Steffen Liebergeld Cc: linux-pci@vger.kernel.org, stable@vger.kernel.org, Andrew Murray , Alex Williamson , Ashok Raj Subject: Re: [PATCH v2] PCI: quirks: Fix register location for UPDCR Message-ID: <20190927125457.GA34765@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a3505df-79ba-8a28-464c-88b83eefffa6@kernkonzept.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Andrew, Alex, Ashok] Please cc people who commented on previous versions of a patch. I added them for you here. This is probably fine, but I'm waiting to see if Ashok gets a response from the chipset folks. Hopefully he can ack this as a simple typo fix. On Wed, Sep 18, 2019 at 03:16:52PM +0200, Steffen Liebergeld wrote: > According to documentation [0] the correct offset for the > Upstream Peer Decode Configuration Register (UPDCR) is 0x1014. > It was previously defined as 0x1114. > > Commit d99321b63b1f intends to enforce isolation between PCI > devices allowing them to be put into separate IOMMU groups. > Due to the wrong register offset the intended isolation was not > fully enforced. This is fixed with this patch. > > Please note that I did not test this patch because I have > no hardware that implements this register. > > [0] > https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/4th-gen-core-family-mobile-i-o-datasheet.pdf > (page 325) > > Fixes: d99321b63b1f ("PCI: Enable quirks for PCIe ACS on Intel PCH root ports") > Reviewed-by: Andrew Murray > Signed-off-by: Steffen Liebergeld > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 208aacf39329..7e184beb2aa4 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4602,7 +4602,7 @@ int pci_dev_specific_acs_enabled(struct pci_dev > *dev, u16 acs_flags) > #define INTEL_BSPR_REG_BPPD (1 << 9) > /* Upstream Peer Decode Configuration Register */ > -#define INTEL_UPDCR_REG 0x1114 > +#define INTEL_UPDCR_REG 0x1014 > /* 5:0 Peer Decode Enable bits */ > #define INTEL_UPDCR_REG_MASK 0x3f > -- 2.11.0 > >