From: Christoph Hellwig <hch@infradead.org>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Minghuan Lian <Minghuan.Lian@nxp.com>,
Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
Subject: Re: [PATCH] PCI: mobiveil: Fix csr_read/write build issue
Date: Fri, 27 Sep 2019 16:15:04 -0700 [thread overview]
Message-ID: <20190927231504.GA13714@infradead.org> (raw)
In-Reply-To: <20190926092933.GC9720@e119886-lin.cambridge.arm.com>
On Thu, Sep 26, 2019 at 10:29:34AM +0100, Andrew Murray wrote:
> Though I'd be just as happy if the csr_[read,write][l,] functions were
> renamed to mobiveil_csr_[read,write][l,].
Please do that instead, using such generic names as csr_* in a driver
is a bad idea, with or without a __ prefix.
next prev parent reply other threads:[~2019-09-27 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 14:21 [PATCH] PCI: mobiveil: Fix csr_read/write build issue Kefeng Wang
2019-09-26 9:29 ` Andrew Murray
2019-09-27 23:15 ` Christoph Hellwig [this message]
2019-09-29 1:35 ` [PATCH v2] " Kefeng Wang
2019-09-30 8:31 ` Andrew Murray
2019-10-04 4:19 ` [PATCH v3] " Kefeng Wang
2019-10-04 8:10 ` Andrew Murray
2019-10-15 15:07 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927231504.GA13714@infradead.org \
--to=hch@infradead.org \
--cc=Minghuan.Lian@nxp.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=andrew.murray@arm.com \
--cc=l.subrahmanya@mobiveil.co.in \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.karthikeyan@mobiveil.co.in \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).