From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F40C352AA for ; Tue, 1 Oct 2019 19:45:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFA1521855 for ; Tue, 1 Oct 2019 19:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569959127; bh=iuEl0oG1KnkC1p6/E5Wz2uBIvJyfmGalS5kJrSPDlLw=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=BkpFJZ3QAPaIp5W5A1r0kniWHeE0B+XG8pGIk9RkVlPAIKeI3TGxM+4KbMYw1zEmm VDlP7ExVHX6KBZ65HCHfmE+WuzhxuvuJME7qah/2YvKZGnXbGWNqoXvBP1etY1hFh/ PigbDZunBic5ZlpzyRAE3Jji19FIW8fR4xi/marM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726010AbfJATpX (ORCPT ); Tue, 1 Oct 2019 15:45:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:56544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbfJATpX (ORCPT ); Tue, 1 Oct 2019 15:45:23 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26F8A205C9; Tue, 1 Oct 2019 19:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569959121; bh=iuEl0oG1KnkC1p6/E5Wz2uBIvJyfmGalS5kJrSPDlLw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=2hV/mPBtGU8oBcPBQvxE26QUIPzRLboN1a7KAwOaOZE1lpPoyVJG5/4rv3CiYrDzN uL1kVj4B0TKChZ7oBo9O48OKM+XZkxEg8M7raFz6GnIiuzvq+gO1KpkNu9loHUiJwF 6tlzF/Y34Z2JKakjjPqBmUkb5VodKqlwihN5ekVs= Date: Tue, 1 Oct 2019 14:45:19 -0500 From: Bjorn Helgaas To: Krzysztof Wilczynski Cc: Joerg Roedel , Jingoo Han , Gustavo Pimentel , Thomas Petazzoni , Frank Rowand , Rob Herring , Lorenzo Pieralisi , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2] PCI: Remove unused includes and superfluous struct declaration Message-ID: <20191001194519.GA63059@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903113059.2901-1-kw@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Sep 03, 2019 at 01:30:59PM +0200, Krzysztof Wilczynski wrote: > Remove and from being included > directly as part of the include/linux/of_pci.h, and remove > superfluous declaration of struct of_phandle_args. > > Move users of include to include > and directly rather than rely on both being > included transitively through . > > Signed-off-by: Krzysztof Wilczynski Applied with Rob's reviewed-by to pci/misc for v5.5, thanks! > --- > drivers/iommu/of_iommu.c | 2 ++ > drivers/irqchip/irq-gic-v2m.c | 1 + > drivers/irqchip/irq-gic-v3-its-pci-msi.c | 1 + > drivers/pci/controller/dwc/pcie-designware-host.c | 1 + > drivers/pci/controller/pci-aardvark.c | 1 + > drivers/pci/controller/pci-thunder-pem.c | 1 + > drivers/pci/pci.c | 1 + > drivers/pci/probe.c | 1 + > include/linux/of_pci.h | 5 ++--- > 9 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c > index 614a93aa5305..026ad2b29dcd 100644 > --- a/drivers/iommu/of_iommu.c > +++ b/drivers/iommu/of_iommu.c > @@ -8,6 +8,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > #include > diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c > index e88e75c22b6a..fbec07d634ad 100644 > --- a/drivers/irqchip/irq-gic-v2m.c > +++ b/drivers/irqchip/irq-gic-v2m.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c > index 229d586c3d7a..87711e0f8014 100644 > --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c > +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index d3156446ff27..7a9bef993e57 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -10,6 +10,7 @@ > > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index fc0fe4d4de49..3a05f6ca95b0 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > > diff --git a/drivers/pci/controller/pci-thunder-pem.c b/drivers/pci/controller/pci-thunder-pem.c > index f127ce8bd4ef..9491e266b1ea 100644 > --- a/drivers/pci/controller/pci-thunder-pem.c > +++ b/drivers/pci/controller/pci-thunder-pem.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 484e35349565..571e7e00984b 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 169943f17a4c..11b11a652d18 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h > index 21a89c4880fa..29658c0ee71f 100644 > --- a/include/linux/of_pci.h > +++ b/include/linux/of_pci.h > @@ -2,11 +2,10 @@ > #ifndef __OF_PCI_H > #define __OF_PCI_H > > -#include > -#include > +#include > +#include > > struct pci_dev; > -struct of_phandle_args; > struct device_node; > > #if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_PCI) > -- > 2.23.0 >