From: Bjorn Helgaas <helgaas@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: msi: remove pci_irq_get_node() as no one is using it
Date: Mon, 14 Oct 2019 10:12:09 -0500 [thread overview]
Message-ID: <20191014151209.GA183158@google.com> (raw)
In-Reply-To: <20191014100452.GA6699@kroah.com>
On Mon, Oct 14, 2019 at 12:04:52PM +0200, Greg Kroah-Hartman wrote:
> The function pci_irq_get_node() is not used by anyone in the tree, so
> just delete it.
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied with Andrew's Reviewed-by to psi/msi for v5.5, thanks!
> ---
>
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 0884bedcfc7a..f95fe23830f0 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -1315,22 +1315,6 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
> }
> EXPORT_SYMBOL(pci_irq_get_affinity);
>
> -/**
> - * pci_irq_get_node - return the NUMA node of a particular MSI vector
> - * @pdev: PCI device to operate on
> - * @vec: device-relative interrupt vector index (0-based).
> - */
> -int pci_irq_get_node(struct pci_dev *pdev, int vec)
> -{
> - const struct cpumask *mask;
> -
> - mask = pci_irq_get_affinity(pdev, vec);
> - if (mask)
> - return local_memory_node(cpu_to_node(cpumask_first(mask)));
> - return dev_to_node(&pdev->dev);
> -}
> -EXPORT_SYMBOL(pci_irq_get_node);
> -
> struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
> {
> return to_pci_dev(desc->dev);
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index f9088c89a534..755d8c0176b9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1454,7 +1454,6 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
> void pci_free_irq_vectors(struct pci_dev *dev);
> int pci_irq_vector(struct pci_dev *dev, unsigned int nr);
> const struct cpumask *pci_irq_get_affinity(struct pci_dev *pdev, int vec);
> -int pci_irq_get_node(struct pci_dev *pdev, int vec);
>
> #else
> static inline int pci_msi_vec_count(struct pci_dev *dev) { return -ENOSYS; }
> @@ -1497,11 +1496,6 @@ static inline const struct cpumask *pci_irq_get_affinity(struct pci_dev *pdev,
> {
> return cpu_possible_mask;
> }
> -
> -static inline int pci_irq_get_node(struct pci_dev *pdev, int vec)
> -{
> - return first_online_node;
> -}
> #endif
>
> /**
prev parent reply other threads:[~2019-10-14 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 10:04 [PATCH] PCI: msi: remove pci_irq_get_node() as no one is using it Greg Kroah-Hartman
2019-10-14 11:01 ` Andrew Murray
2019-10-14 15:12 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014151209.GA183158@google.com \
--to=helgaas@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).