From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-pci@vger.kernel.org, Srinath Mannam <srinath.mannam@broadcom.com>
Subject: Re: [PATCH] PCI: Fix missing bridge dma_ranges resource list cleanup
Date: Mon, 14 Oct 2019 10:22:48 -0500 [thread overview]
Message-ID: <20191014152248.GA189282@google.com> (raw)
In-Reply-To: <20191008012325.25700-1-robh@kernel.org>
On Mon, Oct 07, 2019 at 08:23:25PM -0500, Rob Herring wrote:
> Commit e80a91ad302b ("PCI: Add dma_ranges window list") added a
> dma_ranges resource list, but failed to correctly free the list when
> devm_pci_alloc_host_bridge() is used.
>
> Only the iproc host bridge driver is using the dma_ranges list.
>
> Fixes: e80a91ad302b ("PCI: Add dma_ranges window list")
> Cc: Srinath Mannam <srinath.mannam@broadcom.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to pci/resource for v5.5, thanks!
> ---
> drivers/pci/probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 3d5271a7a849..bdbc8490f962 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -572,6 +572,7 @@ static void devm_pci_release_host_bridge_dev(struct device *dev)
> bridge->release_fn(bridge);
>
> pci_free_resource_list(&bridge->windows);
> + pci_free_resource_list(&bridge->dma_ranges);
> }
>
> static void pci_release_host_bridge_dev(struct device *dev)
> --
> 2.20.1
>
prev parent reply other threads:[~2019-10-14 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 1:23 [PATCH] PCI: Fix missing bridge dma_ranges resource list cleanup Rob Herring
2019-10-14 15:22 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014152248.GA189282@google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).