From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Remi Pommarel <repk@triplefau.lt>
Cc: Yue Wang <yue.wang@Amlogic.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] PCI: amlogic: Fix reset assertion via gpio descriptor
Date: Tue, 15 Oct 2019 15:02:13 +0100 [thread overview]
Message-ID: <20191015140213.GA18503@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190901133915.12899-1-repk@triplefau.lt>
On Sun, Sep 01, 2019 at 03:39:15PM +0200, Remi Pommarel wrote:
> Normally asserting reset signal on gpio would be achieved with:
> gpiod_set_value_cansleep(reset_gpio, 1);
>
> Meson PCI driver set reset value to '0' instead of '1' as it takes into
> account the PERST# signal polarity. The polarity should be taken care
> in the device tree instead.
>
> This fixes the reset assertion meaning and moves out the polarity
> configuration in DT (please note that there is no DT currently using
> this driver).
>
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> ---
> drivers/pci/controller/dwc/pci-meson.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to pci/meson, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index e35e9eaa50ee..541f37a6f6a5 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -287,9 +287,9 @@ static inline void meson_cfg_writel(struct meson_pcie *mp, u32 val, u32 reg)
>
> static void meson_pcie_assert_reset(struct meson_pcie *mp)
> {
> - gpiod_set_value_cansleep(mp->reset_gpio, 0);
> - udelay(500);
> gpiod_set_value_cansleep(mp->reset_gpio, 1);
> + udelay(500);
> + gpiod_set_value_cansleep(mp->reset_gpio, 0);
> }
>
> static void meson_pcie_init_dw(struct meson_pcie *mp)
> --
> 2.20.1
>
prev parent reply other threads:[~2019-10-15 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 13:39 [PATCH] PCI: amlogic: Fix reset assertion via gpio descriptor Remi Pommarel
2019-09-01 21:46 ` Martin Blumenstingl
2019-09-02 8:11 ` Neil Armstrong
2019-09-02 10:55 ` Andrew Murray
2019-09-02 14:43 ` Remi Pommarel
2019-09-02 22:34 ` Martin Blumenstingl
2019-10-15 14:02 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015140213.GA18503@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=repk@triplefau.lt \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).