linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
	Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
Cc: linux-pci@vger.kernel.org
Subject: Mobiveil legacy IRQ binding erroneous interrupt-map
Date: Wed, 16 Oct 2019 11:31:56 +0100	[thread overview]
Message-ID: <20191016103156.GC22848@e121166-lin.cambridge.arm.com> (raw)

Hi Hou, Karthikeyan,

I have just noticed the mobiveil interrupt-map DT bindings example
is wrong:

This:

interrupt-map = <0 0 0 0 &pci_express 0>,
		<0 0 0 1 &pci_express 1>,
		<0 0 0 2 &pci_express 2>,
		<0 0 0 3 &pci_express 3>;

should be:

interrupt-map = <0 0 0 1 &pci_express 0>,
		<0 0 0 2 &pci_express 1>,
		<0 0 0 3 &pci_express 2>,
		<0 0 0 4 &pci_express 3>;

Legacy IRQs Interrupt pins map this way:

{{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}

(as read from Interrupt pin register in the config space header) (ie
refer to PCI local bus specification 3.0), please fix it as soon as
possible.

Lorenzo

             reply	other threads:[~2019-10-16 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 10:31 Lorenzo Pieralisi [this message]
2019-10-29 11:38 ` Mobiveil legacy IRQ binding erroneous interrupt-map Z.q. Hou
2019-10-29 11:50   ` Karthikeyan Mitran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016103156.GC22848@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).