From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF426CA9EC0 for ; Mon, 28 Oct 2019 23:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9706421835 for ; Mon, 28 Oct 2019 23:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572305255; bh=bjSV5yV8N18Dq9EKwCo1gotWA9fJzywtcEjkGdWpJOA=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=KQ/llyGgnhDP9Y0CQd/QEOzoUsced/FI9pp34lFs2gqzm4OldvhP6a0M2Bl3olGIf qf49eu5uY+ImhAEFBtazzmndkrG7Z7O/jWLY6H/OKk+JfymRZElHZjUoZV+wN4d1x7 +a4AQAfNNtx+Roa224lmE2VcpGm0lheNOF1yO3bo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726234AbfJ1X1f (ORCPT ); Mon, 28 Oct 2019 19:27:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:41636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfJ1X1e (ORCPT ); Mon, 28 Oct 2019 19:27:34 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E70BF208C0; Mon, 28 Oct 2019 23:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572305254; bh=bjSV5yV8N18Dq9EKwCo1gotWA9fJzywtcEjkGdWpJOA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nXB7DvZ6vS4pgehWbzRDpiy4VxMcTcMPcUaSmBhBWaMcNr0owOzulO3xp9OZblG5u DpHnxeMehkGewYHi4AP/wznDM6vQJc18YNgXturxdXl9aRAREOY4PFCKhaGk/X6YTu 52vd4z4MZxnhrYt/7G1WnBbi6kFChdewe4jNr1uk= Date: Mon, 28 Oct 2019 18:27:32 -0500 From: Bjorn Helgaas To: sathyanarayanan.kuppuswamy@linux.intel.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, keith.busch@intel.com Subject: Re: [PATCH v9 7/8] PCI/DPC: Clear AER registers in EDR mode Message-ID: <20191028232732.GA206631@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Oct 03, 2019 at 04:39:03PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > As per PCI firmware specification r3.2 Downstream Port Containment > Related Enhancements ECN, Specific reference, please, e.g., the section/table/figure of the PCI Firmware Spec being modified by the ECN. > OS is responsible for clearing the AER > registers in EDR mode. So clear AER registers in dpc_process_error() > function. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Keith Busch > --- > drivers/pci/pcie/dpc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > index fafc55c00fe0..de2d892bc7c4 100644 > --- a/drivers/pci/pcie/dpc.c > +++ b/drivers/pci/pcie/dpc.c > @@ -275,6 +275,10 @@ static void dpc_process_error(struct dpc_dev *dpc) > pci_aer_clear_fatal_status(pdev); > } > > + /* In EDR mode, OS is responsible for clearing AER registers */ > + if (dpc->firmware_dpc) I guess "EDR mode" is effectively the same as "firmware-first mode"? At least, the only place we set "firmware_dpc = 1" is: + if (pcie_aer_get_firmware_first(pdev)) + dpc->firmware_dpc = 1; If they're the same, why do we need two different names for it? > + pci_cleanup_aer_error_status_regs(pdev); > + > /* > * Irrespective of whether the DPC event is triggered by > * ERR_FATAL or ERR_NONFATAL, since the link is already down, > -- > 2.21.0 >