From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com, keith.busch@intel.com
Subject: Re: [PATCH v9 5/8] PCI/AER: Allow clearing Error Status Register in FF mode
Date: Tue, 29 Oct 2019 18:03:46 -0500 [thread overview]
Message-ID: <20191029230346.GA123765@google.com> (raw)
In-Reply-To: <be6df02f-a14f-d80e-0fa2-ff34f19cbcb9@linux.intel.com>
On Tue, Oct 29, 2019 at 12:58:14PM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 10/28/19 4:22 PM, Bjorn Helgaas wrote:
> > On Thu, Oct 03, 2019 at 04:39:01PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > > @@ -430,9 +424,6 @@ int pci_cleanup_aer_error_status_regs(struct pci_dev *dev)
> > > if (!pos)
> > > return -EIO;
> > > - if (pcie_aer_get_firmware_first(dev))
> > > - return -EIO;
> > > -
> > > port_type = pci_pcie_type(dev);
> > > if (port_type == PCI_EXP_TYPE_ROOT_PORT) {
> > > pci_read_config_dword(dev, pos + PCI_ERR_ROOT_STATUS, &status);
> > > @@ -455,7 +446,8 @@ void pci_aer_init(struct pci_dev *dev)
> > > if (dev->aer_cap)
> > > dev->aer_stats = kzalloc(sizeof(struct aer_stats), GFP_KERNEL);
> > > - pci_cleanup_aer_error_status_regs(dev);
> > > + if (!pcie_aer_get_firmware_first(dev))
> > > + pci_cleanup_aer_error_status_regs(dev);
> >
> > This effectively moves the "if (pcie_aer_get_firmware_first())" check
> > from pci_cleanup_aer_error_status_regs() into one of the callers. But
> > there are two other callers: pci_aer_init() and pci_restore_state().
> > Do they need the change, or do you want to cleanup the AER error
> > registers there, but not here?
>
> Good catch. I have added this check to pci_aer_init(). But it needs
> to be added to pci_restore_state() as well. Instead of moving the
> checks to the caller, If you agree, I could change the API to
> pci_cleanup_aer_error_status_regs(struct pci_dev *dev, bool
> skip_ff_check) and let the caller decide whether they want skip the
> check or not.
If all callers of pci_cleanup_aer_error_status_regs() would have to
check pcie_aer_get_firmware_first(), I don't understand why you're
moving the check at all.
next prev parent reply other threads:[~2019-10-29 23:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 23:38 [PATCH v9 0/8] Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2019-10-03 23:38 ` [PATCH v9 1/8] PCI/ERR: Update error status after reset_link() sathyanarayanan.kuppuswamy
2019-10-03 23:38 ` [PATCH v9 2/8] PCI/DPC: Allow dpc_probe() even if firmware first mode is enabled sathyanarayanan.kuppuswamy
2019-10-03 23:38 ` [PATCH v9 3/8] PCI/DPC: Add dpc_process_error() wrapper function sathyanarayanan.kuppuswamy
2019-10-03 23:39 ` [PATCH v9 4/8] PCI/DPC: Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2019-10-03 23:39 ` [PATCH v9 5/8] PCI/AER: Allow clearing Error Status Register in FF mode sathyanarayanan.kuppuswamy
2019-10-28 23:22 ` Bjorn Helgaas
2019-10-29 19:58 ` Kuppuswamy Sathyanarayanan
2019-10-29 23:03 ` Bjorn Helgaas [this message]
2019-10-29 23:17 ` Kuppuswamy Sathyanarayanan
2019-10-03 23:39 ` [PATCH v9 6/8] PCI/DPC: Update comments related to DPC recovery on NON_FATAL errors sathyanarayanan.kuppuswamy
2019-10-03 23:39 ` [PATCH v9 7/8] PCI/DPC: Clear AER registers in EDR mode sathyanarayanan.kuppuswamy
2019-10-28 23:27 ` Bjorn Helgaas
2019-10-29 20:04 ` Kuppuswamy Sathyanarayanan
2019-10-29 22:48 ` Bjorn Helgaas
2019-10-29 23:37 ` Kuppuswamy Sathyanarayanan
2019-10-03 23:39 ` [PATCH v9 8/8] PCI/ACPI: Enable EDR support sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029230346.GA123765@google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).