From: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"logang@deltatee.com" <logang@deltatee.com>
Subject: Re: [PATCH v10 4/4] PCI: Allow extend_bridge_window() to shrink resource if necessary
Date: Wed, 30 Oct 2019 15:49:39 +0200 [thread overview]
Message-ID: <20191030134939.GG2593@lahna.fi.intel.com> (raw)
In-Reply-To: <SL2P216MB0187F0B0630B8C5950342CA680600@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
On Wed, Oct 30, 2019 at 01:33:26PM +0000, Nicholas Johnson wrote:
> On Wed, Oct 30, 2019 at 03:25:09PM +0200, mika.westerberg@linux.intel.com wrote:
> > On Wed, Oct 30, 2019 at 12:47:44PM +0000, Nicholas Johnson wrote:
> > > Remove checks for resource size in extend_bridge_window(). This is
> > > necessary to allow the pci_bus_distribute_available_resources() to
> > > function when the kernel parameter pci=hpmemsize=nn[KMG] is used to
> > > allocate resources. Because the kernel parameter sets the size of all
> > > hotplug bridges to be the same, there are problems when nested hotplug
> > > bridges are encountered. Fitting a downstream hotplug bridge with size X
> > > and normal bridges with non-zero size Y into parent hotplug bridge with
> > > size X is impossible, and hence the downstream hotplug bridge needs to
> > > shrink to fit into its parent.
> > >
> > > Add check for if bridge is extended or shrunken and adjust pci_dbg to
> > > reflect this.
> > >
> > > Reset the resource if its new size is zero (if we have run out of a
> > > bridge window resource) to prevent the PCI resource assignment code from
> > > attempting to assign a zero-sized resource.
> > >
> > > Rename extend_bridge_window() to adjust_bridge_window() to reflect the
> > > fact that the window can now shrink.
> > >
> > > Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
> >
> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Do I need to re-post with this line in it?
No. Typically maintainers add these when they apply the patch.
next prev parent reply other threads:[~2019-10-30 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 12:47 [PATCH v10 4/4] PCI: Allow extend_bridge_window() to shrink resource if necessary Nicholas Johnson
2019-10-30 13:25 ` mika.westerberg
2019-10-30 13:33 ` Nicholas Johnson
2019-10-30 13:49 ` mika.westerberg [this message]
2019-10-31 14:34 ` Nicholas Johnson
-- strict thread matches above, loose matches on Subject: below --
2019-11-13 13:57 Nicholas Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030134939.GG2593@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox