From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48089C432C0 for ; Tue, 19 Nov 2019 19:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EC82223B0 for ; Tue, 19 Nov 2019 19:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574193128; bh=Dx/RbVspBQhDjNXYtTuVzSuF1M6po71LUEwjGlynMM8=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=uZV9Ieb2zgYpJW2vEKgAxCL+0zroeWfQJF0vbH7E2Rn/SUI4TWiby30AKo/wsTQw1 55WfCzG3mYsrwHwjnnoiFv0XIgDBUDO6w9LsTK8F7ylyhA+ftq3NnZf3AlWei/R/Yl 7pB2zGdUwT+NNbgbxzT6GnP6XT4xzCLeN3y/v9fk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbfKSTwH (ORCPT ); Tue, 19 Nov 2019 14:52:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:43632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfKSTwH (ORCPT ); Tue, 19 Nov 2019 14:52:07 -0500 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0ABA222DC; Tue, 19 Nov 2019 19:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574193127; bh=Dx/RbVspBQhDjNXYtTuVzSuF1M6po71LUEwjGlynMM8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=zGFheukLahWwEbQMRW1GKTdM25Vs92hQNlYvYxij4D7WS1Ll8eZWBrz/H7RfwX/RM uxjN6vzQHOjKVIohCxdiQMopfhJH83eWGUFSg5t/lLB5y2vV2It2P3DZoaCGTxyCRm W1dy168FUcZHAE+phxbct0BTZyzQiHeAigmM+5Kw= Date: Tue, 19 Nov 2019 13:52:05 -0600 From: Bjorn Helgaas To: Jay Fang Cc: linux-pci@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH] PCI/AER: Fix AER/sysfs sriov_numvfs deadlock in pcie_do_recovery() Message-ID: <20191119195205.GA210735@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Nov 19, 2019 at 04:57:30PM +0800, Jay Fang wrote: > On 2019/11/15 6:39, Bjorn Helgaas wrote: > > On Fri, Sep 06, 2019 at 10:33:58AM +0800, Jay Fang wrote: > >> A deadlock triggered by a NONFATAL AER event during a sysfs "sriov_numvfs" > >> operation: > > > > How often does this happen? Always? Only when an AER event races > > with the sysfs write? > Although not very frequent,the impact is fatal. This bug is very > necessary to be fixed. Absolutely; I didn't mean to suggest that we shouldn't fix it. I only wanted to know how to prioritize it against other issues. Bjorn