From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: emamd001@umn.edu, Navid Emamdoost <navid.emamdoost@gmail.com>
Subject: [PATCH] PCI/IOV: Fix memory leak in pci_iov_add_virtfn()
Date: Fri, 22 Nov 2019 13:31:36 -0600 [thread overview]
Message-ID: <20191122193138.19278-1-navid.emamdoost@gmail.com> (raw)
In the implementation of pci_iov_add_virtfn() the allocated virtfn is
leaked if pci_setup_device() fails. The error handling is not calling
pci_stop_and_remove_bus_device(). Change the goto label to failed2.
Fixes: 156c55325d30 ("PCI: Check for pci_setup_device() failure in pci_iov_add_virtfn()")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/pci/iov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index b3f972e8cfed..713660482feb 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -164,7 +164,7 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)
rc = pci_setup_device(virtfn);
if (rc)
- goto failed1;
+ goto failed2;
virtfn->dev.parent = dev->dev.parent;
virtfn->multifunction = 0;
--
2.17.1
next reply other threads:[~2019-11-22 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 19:31 Navid Emamdoost [this message]
2019-11-25 18:04 ` [PATCH] PCI/IOV: Fix memory leak in pci_iov_add_virtfn() Nathan Chancellor
2019-11-25 19:33 ` Navid Emamdoost
2019-11-25 19:52 ` [PATCH v2] " Navid Emamdoost
2019-11-26 23:35 ` Bjorn Helgaas
2019-11-28 7:08 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122193138.19278-1-navid.emamdoost@gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=bhelgaas@google.com \
--cc=emamd001@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).