From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DB8C432C0 for ; Tue, 3 Dec 2019 14:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 267BF2068E for ; Tue, 3 Dec 2019 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575384151; bh=X0tSYbxhCgxkGi0QUqni+3iiK1EwhvPfsy2UsM12iAY=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=Y7jKwRDbOlZ/0tzoiAPvb4tEnyOZiqURtEkGuDSMuriMTMQ1lRM7JqqIJv6EqO3vr +w4qrWgglkJR0f1RBV5i91oOgL/2OIkIteDlNi12ytWWaheQk2+vszy677XmDZKcm1 a0B+DMoU5mdHfLt8YNoKRervJiKLuM70owo31cng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726057AbfLCOma (ORCPT ); Tue, 3 Dec 2019 09:42:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:55206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbfLCOma (ORCPT ); Tue, 3 Dec 2019 09:42:30 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 882D420661; Tue, 3 Dec 2019 14:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575384149; bh=X0tSYbxhCgxkGi0QUqni+3iiK1EwhvPfsy2UsM12iAY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=p4aDQItokXXJj8o5Ey/eviueffDtwz0GdZ4C8KFI0W+7eIuaCtHK+sPIFmzoNOrOD aPJMROb4YyE4jcJ31MMo5c091ibWV5urkso0ssUGH7DUq4IFsDKMwBXbOBMNoBi+eo dPZ3Lqd258OB2j15NlG11T6xaDfDf23FgS/gYNdg= Date: Tue, 3 Dec 2019 08:42:26 -0600 From: Bjorn Helgaas To: Wei Liu Cc: linux-pci@vger.kernel.org, rjui@broadcom.com Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally Message-ID: <20191203144226.GA255690@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Dec 03, 2019 at 02:06:57PM +0000, Wei Liu wrote: > On Wed, 27 Nov 2019 at 10:59, Wei Liu wrote: > > > > On Tue, 26 Nov 2019 at 23:05, Bjorn Helgaas wrote: > > > > > > On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote: > > > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built > > > > in. Removing the ifdef will allow us to build the driver as a module. > > > > > > > > Signed-off-by: Wei Liu > > > > > > Sorry, I missed this thinking it would be under drivers/pci/controller > > > and hence handled by Lorenzo. > > > > > > So I guess this doesn't fix a build problem, but without this patch, > > > we just don't run the quirk if the driver is a module, right? > > > > Yes, this is correct. > > > > Without this patch, the quirk doesn't get to run if the driver is a module. > > Are you satisfied with the patch? What do I need to do to get it merged? You needn't do anything. I'll clarify the changelog (the patch doesn't actually *enable* building the driver as a module; it merely ensures that we include the quirk in that case). This is too late for v5.5, so it will get merged for v5.6 unless the modular driver itself was enabled for v5.5. Bjorn