From: Bjorn Helgaas <helgaas@kernel.org>
To: Wei Liu <wei.liu@kernel.org>
Cc: linux-pci@vger.kernel.org, rjui@broadcom.com
Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally
Date: Tue, 10 Dec 2019 18:09:32 -0600 [thread overview]
Message-ID: <20191211000932.GA178707@google.com> (raw)
In-Reply-To: <20191115135842.119621-1-wei.liu@kernel.org>
On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote:
> CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built
> in. Removing the ifdef will allow us to build the driver as a module.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> Alternatively, we can change the condition to:
>
> #ifdef CONFIG_PCIE_IPROC_PLATFORM || CONFIG_PCIE_IPROC_PLATFORM_MODULE
> .
>
> I chose to remove the ifdef because that's what other quirks looked like
> in this file.
> ---
> drivers/pci/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 320255e5e8f8..cd0e7c18e717 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2381,7 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
> PCI_DEVICE_ID_TIGON3_5719,
> quirk_brcm_5719_limit_mrrs);
>
> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
> static void quirk_paxc_bridge(struct pci_dev *pdev)
> {
> /*
> @@ -2405,7 +2404,6 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> -#endif
Is there a reason this quirk can't be moved to
drivers/pci/controller/pcie-iproc-platform.c? That would make it much
less subtle because it would be compiled if and only if the driver
itself is compiled.
If it needs to be here in quirks.c, please include a note about the
reason.
> /*
> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
> --
> 2.24.0
>
next prev parent reply other threads:[~2019-12-11 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 13:58 [PATCH] PCI: build Broadcom PAXC quirks unconditionally Wei Liu
2019-11-25 14:55 ` Wei Liu
2019-11-25 17:39 ` Ray Jui
2019-11-25 17:39 ` Ray Jui
2019-11-26 23:05 ` Bjorn Helgaas
2019-11-27 10:59 ` Wei Liu
2019-12-03 14:06 ` Wei Liu
2019-12-03 14:42 ` Bjorn Helgaas
2019-12-03 14:46 ` Wei Liu
2019-12-11 0:09 ` Bjorn Helgaas [this message]
2019-12-11 0:28 ` Ray Jui
2019-12-11 0:34 ` Bjorn Helgaas
2019-12-11 0:42 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211000932.GA178707@google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).