From: Christoph Hellwig <hch@lst.de>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
iommu@lists.linux-foundation.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v4 4/7] iommu/vt-d: Use pci_real_dma_dev() for mapping
Date: Sun, 19 Jan 2020 23:18:43 +0100 [thread overview]
Message-ID: <20200119221843.GA4759@lst.de> (raw)
In-Reply-To: <1579278449-174098-5-git-send-email-jonathan.derrick@intel.com>
On Fri, Jan 17, 2020 at 09:27:26AM -0700, Jon Derrick wrote:
> + if (dev_is_pci(dev)) {
> + struct pci_dev *pdev;
> +
> + pdev = pci_real_dma_dev(to_pci_dev(dev));
> + dev = &pdev->dev;
I think this could be simplified to
if (dev_is_pci(dev))
dev = &pci_real_dma_dev(to_pci_dev(dev)->dev;
next prev parent reply other threads:[~2020-01-19 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 16:27 [PATCH v4 0/7] Clean up VMD DMA Map Ops Jon Derrick
2020-01-17 16:27 ` [PATCH v4 1/7] x86/PCI: Add a to_pci_sysdata helper Jon Derrick
2020-01-17 16:27 ` [PATCH v4 2/7] x86/PCI: Expose VMD's PCI Device in pci_sysdata Jon Derrick
2020-01-17 16:27 ` [PATCH v4 3/7] PCI: Introduce pci_real_dma_dev() Jon Derrick
2020-01-17 16:27 ` [PATCH v4 4/7] iommu/vt-d: Use pci_real_dma_dev() for mapping Jon Derrick
2020-01-19 22:18 ` Christoph Hellwig [this message]
2020-01-21 1:06 ` Lu Baolu
2020-01-21 1:22 ` Derrick, Jonathan
2020-01-17 16:27 ` [PATCH v4 5/7] iommu/vt-d: Remove VMD child device sanity check Jon Derrick
2020-01-17 16:27 ` [PATCH v4 6/7] PCI: vmd: Stop overriding dma_map_ops Jon Derrick
2020-01-20 10:58 ` Lorenzo Pieralisi
2020-01-17 16:27 ` [PATCH v4 7/7] x86/PCI: Remove X86_DEV_DMA_OPS Jon Derrick
2020-01-19 22:25 ` [PATCH v4 0/7] Clean up VMD DMA Map Ops Christoph Hellwig
2020-01-20 11:02 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119221843.GA4759@lst.de \
--to=hch@lst.de \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.derrick@intel.com \
--cc=joro@8bytes.org \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).