* [PATCH] PCI: brcmstb: fix resource_size.cocci warnings
[not found] <202001270436.kA25JaWy%lkp@intel.com>
@ 2020-01-26 20:09 ` kbuild test robot
2020-01-27 9:31 ` Nicolas Saenz Julienne
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-01-26 20:09 UTC (permalink / raw)
To: Jim Quinlan
Cc: kbuild-all, Lorenzo Pieralisi, Nicolas Saenz Julienne,
Andrew Murray, Jeremy Linton, Bjorn Helgaas, Florian Fainelli,
bcm-kernel-feedback-list, linux-pci, linux-arm-kernel
From: kbuild test robot <lkp@intel.com>
drivers/pci/controller/pcie-brcmstb.c:552:13-16: ERROR: Missing resource_size with res
Use resource_size function on resource object
instead of explicit computation.
Generated by: scripts/coccinelle/api/resource_size.cocci
Fixes: 8ad90d975e00 ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
CC: Jim Quinlan <james.quinlan@broadcom.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 702ccea170f07783bd002055a353a0866c062267
commit: 8ad90d975e00c297a198f6ecbd65e414fbb06dc9 [8319/11283] PCI: brcmstb: Add Broadcom STB PCIe host controller driver
pcie-brcmstb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -549,7 +549,7 @@ static int brcm_pcie_setup(struct brcm_p
brcm_pcie_set_outbound_win(pcie, num_out_wins, res->start,
res->start - entry->offset,
- res->end - res->start + 1);
+ resource_size(res));
num_out_wins++;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: brcmstb: fix resource_size.cocci warnings
2020-01-26 20:09 ` [PATCH] PCI: brcmstb: fix resource_size.cocci warnings kbuild test robot
@ 2020-01-27 9:31 ` Nicolas Saenz Julienne
2020-01-27 10:33 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Saenz Julienne @ 2020-01-27 9:31 UTC (permalink / raw)
To: kbuild test robot, Jim Quinlan
Cc: kbuild-all, Lorenzo Pieralisi, Nicolas Saenz Julienne,
Andrew Murray, Jeremy Linton, Bjorn Helgaas, Florian Fainelli,
bcm-kernel-feedback-list, linux-pci, linux-arm-kernel
On Mon Jan 27, 2020 at 4:09 AM, kbuild test robot wrote:
> From: kbuild test robot <lkp@intel.com>
>
> drivers/pci/controller/pcie-brcmstb.c:552:13-16: ERROR: Missing
> resource_size with res
>
>
> Use resource_size function on resource object
> instead of explicit computation.
>
> Generated by: scripts/coccinelle/api/resource_size.cocci
>
> Fixes: 8ad90d975e00 ("PCI: brcmstb: Add Broadcom STB PCIe host
> controller driver")
> CC: Jim Quinlan <james.quinlan@broadcom.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Regards,
Nicolas
>
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> head: 702ccea170f07783bd002055a353a0866c062267
> commit: 8ad90d975e00c297a198f6ecbd65e414fbb06dc9 [8319/11283] PCI:
> brcmstb: Add Broadcom STB PCIe host controller driver
>
> pcie-brcmstb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -549,7 +549,7 @@ static int brcm_pcie_setup(struct brcm_p
>
> brcm_pcie_set_outbound_win(pcie, num_out_wins, res->start,
> res->start - entry->offset,
> - res->end - res->start + 1);
> + resource_size(res));
> num_out_wins++;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: brcmstb: fix resource_size.cocci warnings
2020-01-27 9:31 ` Nicolas Saenz Julienne
@ 2020-01-27 10:33 ` Lorenzo Pieralisi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-01-27 10:33 UTC (permalink / raw)
To: Nicolas Saenz Julienne
Cc: kbuild test robot, Jim Quinlan, kbuild-all, Andrew Murray,
Jeremy Linton, Bjorn Helgaas, Florian Fainelli,
bcm-kernel-feedback-list, linux-pci, linux-arm-kernel
On Mon, Jan 27, 2020 at 10:31:22AM +0100, Nicolas Saenz Julienne wrote:
> On Mon Jan 27, 2020 at 4:09 AM, kbuild test robot wrote:
> > From: kbuild test robot <lkp@intel.com>
> >
> > drivers/pci/controller/pcie-brcmstb.c:552:13-16: ERROR: Missing
> > resource_size with res
> >
> >
> > Use resource_size function on resource object
> > instead of explicit computation.
> >
> > Generated by: scripts/coccinelle/api/resource_size.cocci
> >
> > Fixes: 8ad90d975e00 ("PCI: brcmstb: Add Broadcom STB PCIe host
> > controller driver")
> > CC: Jim Quinlan <james.quinlan@broadcom.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
>
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Applied on top on pci/brcmstb, thanks.
Lorenzo
> Regards,
> Nicolas
>
> >
> > tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > head: 702ccea170f07783bd002055a353a0866c062267
> > commit: 8ad90d975e00c297a198f6ecbd65e414fbb06dc9 [8319/11283] PCI:
> > brcmstb: Add Broadcom STB PCIe host controller driver
> >
> > pcie-brcmstb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/pci/controller/pcie-brcmstb.c
> > +++ b/drivers/pci/controller/pcie-brcmstb.c
> > @@ -549,7 +549,7 @@ static int brcm_pcie_setup(struct brcm_p
> >
> > brcm_pcie_set_outbound_win(pcie, num_out_wins, res->start,
> > res->start - entry->offset,
> > - res->end - res->start + 1);
> > + resource_size(res));
> > num_out_wins++;
> > }
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-27 10:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202001270436.kA25JaWy%lkp@intel.com>
2020-01-26 20:09 ` [PATCH] PCI: brcmstb: fix resource_size.cocci warnings kbuild test robot
2020-01-27 9:31 ` Nicolas Saenz Julienne
2020-01-27 10:33 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).