From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB88C32771 for ; Mon, 27 Jan 2020 10:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D458C206D3 for ; Mon, 27 Jan 2020 10:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729536AbgA0KdU (ORCPT ); Mon, 27 Jan 2020 05:33:20 -0500 Received: from foss.arm.com ([217.140.110.172]:42350 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729099AbgA0KdU (ORCPT ); Mon, 27 Jan 2020 05:33:20 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7371F30E; Mon, 27 Jan 2020 02:33:19 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F09093F52E; Mon, 27 Jan 2020 02:33:17 -0800 (PST) Date: Mon, 27 Jan 2020 10:33:08 +0000 From: Lorenzo Pieralisi To: Nicolas Saenz Julienne Cc: kbuild test robot , Jim Quinlan , kbuild-all@lists.01.org, Andrew Murray , Jeremy Linton , Bjorn Helgaas , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: brcmstb: fix resource_size.cocci warnings Message-ID: <20200127103300.GA25542@e121166-lin.cambridge.arm.com> References: <20200126200939.k3vcseaccp3buh4z@f53c9c00458a> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jan 27, 2020 at 10:31:22AM +0100, Nicolas Saenz Julienne wrote: > On Mon Jan 27, 2020 at 4:09 AM, kbuild test robot wrote: > > From: kbuild test robot > > > > drivers/pci/controller/pcie-brcmstb.c:552:13-16: ERROR: Missing > > resource_size with res > > > > > > Use resource_size function on resource object > > instead of explicit computation. > > > > Generated by: scripts/coccinelle/api/resource_size.cocci > > > > Fixes: 8ad90d975e00 ("PCI: brcmstb: Add Broadcom STB PCIe host > > controller driver") > > CC: Jim Quinlan > > Signed-off-by: kbuild test robot > > --- > > Reviewed-by: Nicolas Saenz Julienne Applied on top on pci/brcmstb, thanks. Lorenzo > Regards, > Nicolas > > > > > tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > master > > head: 702ccea170f07783bd002055a353a0866c062267 > > commit: 8ad90d975e00c297a198f6ecbd65e414fbb06dc9 [8319/11283] PCI: > > brcmstb: Add Broadcom STB PCIe host controller driver > > > > pcie-brcmstb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/pci/controller/pcie-brcmstb.c > > +++ b/drivers/pci/controller/pcie-brcmstb.c > > @@ -549,7 +549,7 @@ static int brcm_pcie_setup(struct brcm_p > > > > brcm_pcie_set_outbound_win(pcie, num_out_wins, res->start, > > res->start - entry->offset, > > - res->end - res->start + 1); > > + resource_size(res)); > > num_out_wins++; > > } > > >