Re: [RFC PATCH 0/2] lspci: support for CCIX DVSEC

Martin Mareš
2020-01-22T09:47:27Z

Hello!

> This series adds support for near complete interpretation of CCIX DVSEC.
> Most of the CCIX base 1.0 specification is covered, but a few minor
> elements are not currently printed (some of the timeouts and credit
> types). That can be rectified in a future version or follow up patch
> and isn't necessary for this discussion.
>
> CCIX (www.ccixconsortium.org) is a coherent interconnect specification.
> It is flexible in allowed interconnect topologies, but is overlayed
> on top of a traditional PCIe tree. Note that CCIX physical devices
> may turn up in a number of different locations in the PCIe tree.
>
> The topology configuration and physical layer controls and description
> are presented using PCIe DVSEC structures defined in the CCIX 1.0
> base specification. These use the unique ID granted by the PCISIG.
> Note that, whilst it looks like a Vendor ID for this usecase it is
> not one and can only be used to identify DVSEC and related CCIX protocol
> messages.
>
> So why an RFC?
> * Are the lspci maintainers happy to have the tool include support for
> PCI configuration structures that are defined in other standards?
> * Is the general approach and code structure appropriate?
> * It's a lot of description so chances are some of it isn't in a format
> consistent with the rest of lspci!

I am very happy to include parsers of vendor-specific capabilities.

The general approach is fine, but please bring the source code closer
to the coding style of the rest of pciutils.

> The following grants the 'pciutils' project trademark usage of
> CCIX tradmark where relevant.
>
> This patch is being distributed by the CCIX Consortium, Inc. (CCIX) to
> you and other parties that are paticipating (the "participants") in the
> pciutils with the understanding that the participants will use CCIX's
> name and trademark only when this patch is used in association with the
> pciutils project.

I suspect that this is not compatible with the GPL. Everybody is allowed
to use portions of pciutils in other GPLed projects. So the trademark usage
right should be granted to use in the contributed code, regardless of whether
it is currently in the pciutils project, or any other project.

> CCIX is also distributing this patch to these participants with the
> understanding that if any portion of the CCIX specification will be
> used or referenced in the pciutils project, the participants will not modify
> the cited portion of the CCIX specification and will give CCIX propery
> copyright attribution by including the following copyright notice with
> the cited part of the CCIX specification:
> "© 2019 CCIX CONSORTIUM, INC. ALL RIGHTS RESERVED."

Are there any citations affected by this in your patch? You only refer to data
structures defined by the specification, but this is factual information which
cannot be copyrighted (but IANAL).

I am strongly opposed to adding more copyright notices to the pciutils
besides the GPL.

Have a nice fortnight
--
Martin `MJ' Mareš <mj@ucw.cz> http://mj.ucw.cz/
United Computer Wizards, Prague, Czech Republic, Europe, Earth, Universe
hAS ANYONE SEEN MY cAPSLOCK KEY?