From: Bjorn Helgaas <helgaas@kernel.org>
To: sathyanarayanan.kuppuswamy@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com
Subject: Re: [PATCH v1 1/1] PCI/ATS: For VF PCIe device use PF PASID Capability
Date: Wed, 5 Feb 2020 12:11:31 -0600 [thread overview]
Message-ID: <20200205181131.GA226021@google.com> (raw)
In-Reply-To: <fe891f9755cb18349389609e7fed9940fc5b081a.1580325170.git.sathyanarayanan.kuppuswamy@linux.intel.com>
On Wed, Jan 29, 2020 at 11:14:00AM -0800, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Per PCIe r5.0, sec 9.3.7.14, if a PF implements the PASID Capability,
> the PF PASID configuration is shared by its VFs. VFs must not implement
> their own PASID Capability. But, commit 751035b8dc06 ("PCI/ATS: Cache
> PASID Capability offset") when adding support for PASID Capability
> offset caching, modified the pci_max_pasids() and pci_pasid_features()
> APIs to use PASID Capability offset of VF device instead of using
> PASID Capability offset of associated PF device. This change leads to
> IOMMU bind failures when pci_max_pasids() and pci_pasid_features()
> functions are invoked by PCIe VF devices.
>
> So modify pci_max_pasids() and pci_pasid_features() functions to use
> correct PASID Capability offset.
>
> Fixes: 751035b8dc06 ("PCI/ATS: Cache PASID Capability offset")
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Applied to for-linus for v5.6, thanks! I also added a stable tag
since 751035b8dc06 appeared in v5.5.
> ---
> drivers/pci/ats.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
> index 982b46f0a54d..b6f064c885c3 100644
> --- a/drivers/pci/ats.c
> +++ b/drivers/pci/ats.c
> @@ -424,11 +424,12 @@ void pci_restore_pasid_state(struct pci_dev *pdev)
> int pci_pasid_features(struct pci_dev *pdev)
> {
> u16 supported;
> - int pasid = pdev->pasid_cap;
> + int pasid;
>
> if (pdev->is_virtfn)
> pdev = pci_physfn(pdev);
>
> + pasid = pdev->pasid_cap;
> if (!pasid)
> return -EINVAL;
>
> @@ -451,11 +452,12 @@ int pci_pasid_features(struct pci_dev *pdev)
> int pci_max_pasids(struct pci_dev *pdev)
> {
> u16 supported;
> - int pasid = pdev->pasid_cap;
> + int pasid;
>
> if (pdev->is_virtfn)
> pdev = pci_physfn(pdev);
>
> + pasid = pdev->pasid_cap;
> if (!pasid)
> return -EINVAL;
>
> --
> 2.21.0
>
prev parent reply other threads:[~2020-02-05 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 19:14 [PATCH v1 1/1] PCI/ATS: For VF PCIe device use PF PASID Capability sathyanarayanan.kuppuswamy
2020-02-05 18:11 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205181131.GA226021@google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).