From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com
Subject: Re: [PATCH v15 3/5] PCI/EDR: Export AER, DPC and error recovery functions
Date: Wed, 26 Feb 2020 15:48:55 -0600 [thread overview]
Message-ID: <20200226214855.GA175196@google.com> (raw)
In-Reply-To: <2b37ed9b-3d6f-ea94-4591-86f9d5bbe543@linux.intel.com>
On Wed, Feb 26, 2020 at 01:26:09PM -0800, Kuppuswamy Sathyanarayanan wrote:
> On 2/26/20 1:13 PM, Bjorn Helgaas wrote:
> > On Wed, Feb 26, 2020 at 11:30:43AM -0800, Kuppuswamy Sathyanarayanan wrote:
> > > On 2/25/20 5:02 PM, Bjorn Helgaas wrote:
> > > > On Thu, Feb 13, 2020 at 10:20:15AM -0800, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > > > > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > > > > ...
> > > > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> > > > > index 99fca8400956..acae12dbf9ff 100644
> > > > > --- a/drivers/pci/pcie/dpc.c
> > > > > +++ b/drivers/pci/pcie/dpc.c
> > > > > @@ -15,15 +15,9 @@
> > > > > #include <linux/pci.h>
> > > > > #include "portdrv.h"
> > > > > +#include "dpc.h"
> > > > > #include "../pci.h"
> > > > > -struct dpc_dev {
> > > > > - struct pci_dev *pdev;
> > > > > - u16 cap_pos;
> > > > > - bool rp_extensions;
> > > > > - u8 rp_log_size;
> > > > > -};
> > > > Adding dpc.h shouldn't be in this patch because there's no need for a
> > > > separate dpc.h file yet -- it's only included this one place. I'm not
> > > > positive a dpc.h is needed at all -- see comments on patch [4/5].
> > > Yes, if we use pdev in dpc functions used by EDR code, we should
> > > not need it.
> > I think struct dpc_dev might be more trouble than it's worth. I
> > attached a possible patch at the end that folds the 25 bits of
> > DPC-related info into the struct pci_dev and gets rid of struct
> > dpc_dev completely. I compiled it but haven't tested it.
> That would solve most of my export issues. Do you want me
> to add it to my patch list or merge it separately.
If you want to use that, I would merge it first, followed by the error
clearing cleanup, followed by the other EDR stuff.
Bjorn
next prev parent reply other threads:[~2020-02-26 21:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:20 [PATCH v15 0/5] Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2020-02-13 18:20 ` [PATCH v15 1/5] PCI/ERR: Update error status after reset_link() sathyanarayanan.kuppuswamy
2020-02-26 13:41 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 2/5] PCI/DPC: Remove pcie_device reference from dpc_dev structure sathyanarayanan.kuppuswamy
2020-02-26 13:43 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 3/5] PCI/EDR: Export AER, DPC and error recovery functions sathyanarayanan.kuppuswamy
2020-02-26 1:02 ` Bjorn Helgaas
2020-02-26 19:30 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:13 ` Bjorn Helgaas
2020-02-26 21:26 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:48 ` Bjorn Helgaas [this message]
2020-02-13 18:20 ` [PATCH v15 4/5] PCI/DPC: Add Error Disconnect Recover (EDR) support sathyanarayanan.kuppuswamy
2020-02-26 1:02 ` Bjorn Helgaas
2020-02-26 18:42 ` Kuppuswamy Sathyanarayanan
2020-02-26 21:32 ` Bjorn Helgaas
2020-02-26 22:11 ` Kuppuswamy Sathyanarayanan
2020-02-26 22:41 ` Bjorn Helgaas
2020-02-13 18:20 ` [PATCH v15 5/5] PCI/ACPI: Enable EDR support sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226214855.GA175196@google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).