From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
amurray@thegoodpenguin.co.uk, bhelgaas@google.com
Subject: Re: [PATCH] PCI: mobiveil: fix different address space warnings of sparse
Date: Tue, 17 Mar 2020 15:50:23 +0000 [thread overview]
Message-ID: <20200317155015.GA30120@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200317145125.3682-1-Zhiqiang.Hou@nxp.com>
On Tue, Mar 17, 2020 at 10:51:25PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> Fix the sparse warnings below:
>
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:44:49: warning: incorrect type in return expression (different address spaces)
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:44:49: expected void *
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:44:49: got void [noderef] <asn:2> *
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:48:41: warning: incorrect type in return expression (different address spaces)
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:48:41: expected void *
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:48:41: got void [noderef] <asn:2> *
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:106:34: warning: incorrect type in argument 1 (different address spaces)
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:106:34: expected void [noderef] <asn:2> *addr
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:106:34: got void *[assigned] addr
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:121:35: warning: incorrect type in argument 1 (different address spaces)
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:121:35: expected void [noderef] <asn:2> *addr
> drivers/pci/controller/mobiveil/pcie-mobiveil.c:121:35: got void *[assigned] addr
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> ---
> drivers/pci/controller/mobiveil/pcie-mobiveil.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil.c b/drivers/pci/controller/mobiveil/pcie-mobiveil.c
> index 23ab904989ea..62ecbaeb0a60 100644
> --- a/drivers/pci/controller/mobiveil/pcie-mobiveil.c
> +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil.c
> @@ -36,7 +36,8 @@ static void mobiveil_pcie_sel_page(struct mobiveil_pcie *pcie, u8 pg_idx)
> writel(val, pcie->csr_axi_slave_base + PAB_CTRL);
> }
>
> -static void *mobiveil_pcie_comp_addr(struct mobiveil_pcie *pcie, u32 off)
> +static void __iomem *mobiveil_pcie_comp_addr(struct mobiveil_pcie *pcie,
> + u32 off)
> {
> if (off < PAGED_ADDR_BNDRY) {
> /* For directly accessed registers, clear the pg_sel field */
> @@ -97,7 +98,7 @@ static int mobiveil_pcie_write(void __iomem *addr, int size, u32 val)
>
> u32 mobiveil_csr_read(struct mobiveil_pcie *pcie, u32 off, size_t size)
> {
> - void *addr;
> + void __iomem *addr;
> u32 val;
> int ret;
>
> @@ -113,7 +114,7 @@ u32 mobiveil_csr_read(struct mobiveil_pcie *pcie, u32 off, size_t size)
> void mobiveil_csr_write(struct mobiveil_pcie *pcie, u32 val, u32 off,
> size_t size)
> {
> - void *addr;
> + void __iomem *addr;
> int ret;
>
> addr = mobiveil_pcie_comp_addr(pcie, off);
> --
> 2.17.1
>
prev parent reply other threads:[~2020-03-17 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 14:51 [PATCH] PCI: mobiveil: fix different address space warnings of sparse Zhiqiang Hou
2020-03-17 15:50 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317155015.GA30120@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).