From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EB5C54FCB for ; Fri, 24 Apr 2020 19:30:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FFCA2098B for ; Fri, 24 Apr 2020 19:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587756611; bh=QaWXr2oWtPWMdw0bfTG0RG9QMElIUw6uG1iNTqEcQP4=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=L1TL/NoRHx09qq3nUvETBSpWPV1A5gcxy3B0dfCq3TcN43IgWZkImLZ2GOY/k1A5t TDypBVon1V++zrslGtDwjZNhkhQuAFzziPMCcN8SHyD6yVCOnKKF8kZLB1+AWM1i8C F3Zd5dOOnA3nry+C5ogGZtluI84N8GnvQSrUdBu8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgDXTaK (ORCPT ); Fri, 24 Apr 2020 15:30:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:35624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgDXTaK (ORCPT ); Fri, 24 Apr 2020 15:30:10 -0400 Received: from localhost (mobile-166-175-187-210.mycingular.net [166.175.187.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD95A2075A; Fri, 24 Apr 2020 19:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587756610; bh=QaWXr2oWtPWMdw0bfTG0RG9QMElIUw6uG1iNTqEcQP4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=yU4T3NuXKJSzFqNnh5ZE+IVrif5gAts0WvnOYkC9fcJl9GxBxv6CYAdmwUuHO45ij SYBGzYRStCtxEOwmGrv5G0VGo7/JwnWbXzYz1otZjm8BMZfDl3ofkmAc6zmSf3PPWw QV2u6ogb0JN7wSvWvZXnlAePz7BQJEd2FUEPlOa4= Date: Fri, 24 Apr 2020 14:30:08 -0500 From: Bjorn Helgaas To: Rob Herring Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , linux-omap@vger.kernel.org Subject: Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default Message-ID: <20200424193008.GA177667@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422192957.6lwr3aig4a3dcynr@rob-hp-laptop> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote: > On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Drivers should not be selected by default because that bloats the kernel > > for people who don't need them. > > > > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST. > > > > Signed-off-by: Bjorn Helgaas > > Cc: Kishon Vijay Abraham I > > Cc: linux-omap@vger.kernel.org > > --- > > drivers/pci/controller/dwc/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index 03dcaf65d159..ea335ee7ca8e 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST > > depends on OF && HAS_IOMEM && TI_PIPE3 > > select PCIE_DW_HOST > > select PCI_DRA7XX > > - default y > > Perhaps 'default y if SOC_DRA7XX'? Good idea, I did that.