From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B660FC4CECD for ; Mon, 27 Apr 2020 17:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9383F2087E for ; Mon, 27 Apr 2020 17:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588009301; bh=4+FdGDK3qcemswCFDQJ5mLkfrtJ2whwh+PcMpzPVew4=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=h8BAcRbm98k+eU0279cT+W07Tv59ReUQ4bXEVrxLcjN/OwQ7jsaN9ZAErf0mUTPrz VxACPv1oQpEjrsn6O2+1oW6Gsd17Mf6hGX4/Y0IqWrwQHWfYfiz1Hktk5xEEau3bci vJonVf/NYRqPOochnCPHx46JXmWXOZ2IJfQoMJsA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbgD0Rll (ORCPT ); Mon, 27 Apr 2020 13:41:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgD0Rlk (ORCPT ); Mon, 27 Apr 2020 13:41:40 -0400 Received: from localhost (mobile-166-175-187-210.mycingular.net [166.175.187.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0931B20775; Mon, 27 Apr 2020 17:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588009300; bh=4+FdGDK3qcemswCFDQJ5mLkfrtJ2whwh+PcMpzPVew4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sBSXhyCjUGWmK++mfBvXr0kaSLxdlfr3oeRmvokzZ6lFXclYQyrNdvWgkUaxJcLjZ roYxZ6f4/fHsbu2cjQBPQpCwbR8qTD+06NOnMFQOOSH/GO/WUlTmGgzJANn9arbWMD /ZqYd6YoPtZKptl5pVBNBnm8MfidEqFjLFdYmCRI= Date: Mon, 27 Apr 2020 12:41:38 -0500 From: Bjorn Helgaas To: Geert Uytterhoeven Cc: Marek Vasut , linux-pci , Kazufumi Ikeda , Gaku Inami , Marek Vasut , Geert Uytterhoeven , Phil Edworthy , Simon Horman , Wolfram Sang , Linux-Renesas , Vaibhav Gupta , Lorenzo Pieralisi Subject: Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver Message-ID: <20200427174138.GA207841@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Lorenzo] On Sat, Apr 25, 2020 at 10:55:21AM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 24, 2020 at 9:57 PM Bjorn Helgaas wrote: > > [+cc Vaibhav] > > > > Alternate less redundant subject: > > > > PCI: rcar: Add suspend/resume support > > Note that there's both pcie-rcar.c (this driver, for R-Car Gen2 and Gen3 > PCIe) and pci-rcar-gen2.c (for R-Car Gen2 PCI). > People tend to use the prefix "PCI: rcar: " for both :-( Yeah, that's pretty broken, thanks for pointing this out! For most drivers we use a chipset name ("keystone", "imx6", "tegra", etc) as the changlog tag. That's nice because it gives space for multiple drivers from the same vendor, but I don't know anything similarly specific for the R-Car drivers. pci-rcar-gen2.c seems to be for some sort of internal Conventional PCI bus? The "gen2" is confusing because "Gen 2" is more commonly used for PCIe than for Conventional PCI. I would propose keeping "rcar" for the PCIe driver and using "rcar-pci" for the Conventional PCI one, but the Conventional PCI one (pci-rcar-gen2.c) seems pretty inactive. The most recent commits are from 2018, and they're trivial cleanups. So I'm doubtful that anybody will remember when the next change comes in. Bjorn