From: Bjorn Helgaas <helgaas@kernel.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Thierry Reding <thierry.reding@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error
Date: Wed, 20 May 2020 11:42:30 -0500 [thread overview]
Message-ID: <20200520164230.GA1100990@bjorn-Precision-5520> (raw)
In-Reply-To: <20200520084012.30190-1-dinghao.liu@zju.edu.cn>
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Also This driver forgets to call pm_runtime_disable() when
> pm_runtime_get_sync() returns an error code.
Also, call pm_runtime_disable() when pm_runtime_get_sync() returns
an error code.
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/pci/controller/pci-tegra.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 3e64ba6a36a8..00236dd65b5b 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2712,7 +2712,7 @@ static int tegra_pcie_probe(struct platform_device *pdev)
> err = pm_runtime_get_sync(pcie->dev);
> if (err < 0) {
> dev_err(dev, "fail to enable pcie controller: %d\n", err);
> - goto teardown_msi;
> + goto pm_runtime_put;
> }
>
> host->busnr = bus->start;
> @@ -2746,7 +2746,6 @@ static int tegra_pcie_probe(struct platform_device *pdev)
> pm_runtime_put:
> pm_runtime_put_sync(pcie->dev);
> pm_runtime_disable(pcie->dev);
> -teardown_msi:
> tegra_pcie_msi_teardown(pcie);
> put_resources:
> tegra_pcie_put_resources(pcie);
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-20 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:40 [PATCH] PCI: tegra: fix runtime pm imbalance on error Dinghao Liu
2020-05-20 9:40 ` Thierry Reding
2020-05-20 16:42 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 8:52 Dinghao Liu
2020-05-20 9:59 ` Thierry Reding
2020-05-20 16:37 ` Bjorn Helgaas
2020-05-20 18:09 ` Vidya Sagar
2020-05-29 10:23 ` Lorenzo Pieralisi
2020-05-29 10:58 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520164230.GA1100990@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox